Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect docs or need string extension context argumants implementation #321

Closed
karabanovbs opened this issue Jan 20, 2021 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@karabanovbs
Copy link

StringTranslateExtension tr and plural methods not support context named argument.

https://github.com/aissat/easy_localization/blob/develop/lib/src/public_ext.dart#L63
https://github.com/aissat/easy_localization/blame/develop/README.md#L195

@Overman775
Copy link
Collaborator

@karabanovbs forgot to add import import 'package:easy_localization/easy_localization.dart';

@Overman775 Overman775 added the waiting for customer response Waiting for customer response label Feb 7, 2021
@karabanovbs
Copy link
Author

@Overman775 than not import problem.
context argument not exist in StringTranslateExtension.

@Overman775
Copy link
Collaborator

@karabanovbs needs sample code to reproduce

@karabanovbs
Copy link
Author

@Overman775 reproduce what? difference between docs and implementations?

This code not working. But in docs says that tr have context named argument. But StringTranslateExtension not implement context named argument.

'someString'.tr(context: context)

@Overman775
Copy link
Collaborator

@karabanovbs I understand you, thanks for issue.

@Overman775 Overman775 added bug Something isn't working and removed waiting for customer response Waiting for customer response labels Feb 10, 2021
@Overman775
Copy link
Collaborator

context removed from tr() and plural() in PR #343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants