Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESdriver cleanup #68

Open
Yongyao opened this issue Sep 29, 2016 · 3 comments
Open

ESdriver cleanup #68

Yongyao opened this issue Sep 29, 2016 · 3 comments
Assignees

Comments

@Yongyao
Copy link
Collaborator

Yongyao commented Sep 29, 2016

@quintinali Can you move these two searchbyQuery() used by datasetDetail to somewhere else. Maybe a separate class in search package. It's bit messy here.

https://github.com/mudrod/mudrod/blob/master/core/src/main/java/esiptestbed/mudrod/driver/ESDriver.java#L249

@lewismc
Copy link
Collaborator

lewismc commented Sep 30, 2016

yes it is. We should have a separate ESDriverSearch class.

@quintinali
Copy link
Collaborator

Ok. I will let you know after I do the modification.

@lewismc lewismc removed this from the 10/07/2016 milestone Oct 12, 2016
@lewismc
Copy link
Collaborator

lewismc commented May 3, 2017

The purpose of this issue is to introduce a MudrodDriver.java interface, and for ESDriver.java to begin implementing some of the functions. This is the way it should have been implemented originally. The same should be true for SparkDriver.java. It should merely implement MudrodDriver.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants