Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on python3-pkg-resources #1341

Open
whotwagner opened this issue Oct 7, 2024 · 5 comments · May be fixed by #1351
Open

Dependency on python3-pkg-resources #1341

whotwagner opened this issue Oct 7, 2024 · 5 comments · May be fixed by #1351
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@whotwagner
Copy link
Contributor

Currently we are depending on python3-pkg-resources. Do we really need it? It was more or less replaced by importlib.resources. Maybe we can easily switch to that?

@whotwagner whotwagner added the dependencies Pull requests that update a dependency file label Oct 7, 2024
@ernstleierzopf ernstleierzopf linked a pull request Oct 21, 2024 that will close this issue
9 tasks
@ernstleierzopf
Copy link
Contributor

just tested it and pkg-resources is still needed for python3-cerberus. Even though cerberus was updated to importlib, Ubuntu still uses a 4-year old version.. :/

@whotwagner what is the preferred solution:

  • keep pkg-resources
  • install cerberus with pip

@ernstleierzopf
Copy link
Contributor

just tested it and pkg-resources is still needed for python3-cerberus. Even though cerberus was updated to importlib, Ubuntu still uses a 4-year old version.. :/

@whotwagner what is the preferred solution:

  • keep pkg-resources
  • install cerberus with pip

@landauermax @whotwagner please get back to me so I can resolve this issue.

@whotwagner
Copy link
Contributor Author

just tested it and pkg-resources is still needed for python3-cerberus. Even though cerberus was updated to importlib, Ubuntu still uses a 4-year old version.. :/
@whotwagner what is the preferred solution:

  • keep pkg-resources
  • install cerberus with pip

@landauermax @whotwagner please get back to me so I can resolve this issue.

Let's use cerberus with pip for now. I think we will run into more problems soon because of the recent changes of pip in debian/ubuntu. But let's look at that problem in another issue.

@ernstleierzopf
Copy link
Contributor

currently we are handling the differences with the pip_extra_args variable which uses --break-system-packages when needed.
Obviously this is not the right way of doing things. If you want me to change aminer-ansible to use venvs, just create an issue for it.

@ernstleierzopf
Copy link
Contributor

Please review the changes in the aminer-ansible PR and PR #1351.
Tested and working by exchanging the aminer-ansible repository to mine at ernstleierzopf/aminer-ansible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants