From 870a73f93039983d9431255e414fbc64e3dfd83a Mon Sep 17 00:00:00 2001 From: Googler Date: Tue, 11 Oct 2022 01:17:51 -0700 Subject: [PATCH] Automated rollback of commit 174c67f0911c1cb013658f9b2b2d8959d6ef388c. *** Reason for rollback *** The flip of this flag triggered some bug, the fix is in progress but rollback first to get a green downstream https://github.com/bazelbuild/bazel/issues/16446 *** Original change description *** Default --incompatible_enforce_config_setting_visibility to true. Fixes https://github.com/bazelbuild/bazel/issues/12932. PiperOrigin-RevId: 480281435 Change-Id: If6b45540fb21ba78fcafbca515d285f3e84932f0 --- .../google/devtools/build/lib/pkgcache/PackageOptions.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/main/java/com/google/devtools/build/lib/pkgcache/PackageOptions.java b/src/main/java/com/google/devtools/build/lib/pkgcache/PackageOptions.java index 44574dd4b2efc5..e0ae0ba93f2fba 100644 --- a/src/main/java/com/google/devtools/build/lib/pkgcache/PackageOptions.java +++ b/src/main/java/com/google/devtools/build/lib/pkgcache/PackageOptions.java @@ -122,9 +122,7 @@ public ParallelismConverter() throws OptionsParsingException { @Option( name = "incompatible_enforce_config_setting_visibility", - // TODO(b/179944632): set this and --incompatible_config_setting_private_default_visibility - // to true, then make these no-ops, then remove. - defaultValue = "true", + defaultValue = "false", documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS, effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS}, metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},