Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Aiven-specific changes on top of upstream 4.1.5 #24

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Apply Aiven-specific changes on top of upstream 4.1.5 #24

merged 4 commits into from
Jun 20, 2024

Conversation

tilman-aiven
Copy link

@tilman-aiven tilman-aiven commented Jun 19, 2024 •
edited
Loading

meatlink added 4 commits June 19, 2024 10:23
@meatlink @tilman-aiven
Add Github Action running tests
e1603cd
@meatlink @tilman-aiven
Optionally skip streaming when replacing nodes
ee74cf1 
The data will be provided by Astacus, streaming from other nodes is not
necessary.
@meatlink @tilman-aiven
Add replace_address_first_boot to yaml config
6076e0e 
It's more convenient to set it there in Astacus. Option semantics is
preserved, the value specified in Java properties has priority.
@meatlink @tilman-aiven
Stop advertising Aiven custom authenticator
322b382 
We decorate standard PasswordAuthenticator with a few platform specific
features, that don't change the externally observable behavior - so it's
absolutely compatible with PasswordAuthenticator.

A few tools and client libraries do not support custom authenticators.
For example: ZDM Proxy. They fail whenever they see anything but
PasswordAuthenticator nevertheless they are in fact completely
compatible.

So we want to stop advertising our custom authenticator and pretend that
it's a standard PasswordAuthenticator.
@tilman-aiven tilman-aiven requested review from aris-aiven and a team June 19, 2024 09:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

Unit Test Results

7 037 tests   6 982 ✔️  1h 28m 10s ⏱️
   850 suites       54 💤
   850 files           1 ❌

For more details on these failures, see this check.

Results for commit 322b382.

♻️ This comment has been updated with latest results.

@tilman-aiven
Copy link
Author

testSize[skiplist] (org.apache.cassandra.cql3.MemtableSizeTest) failed (warning)

junit.framework.AssertionFailedError: Expected heap usage close to 75.526MiB, got 71.473MiB.

	at org.apache.cassandra.cql3.MemtableSizeTest.testSizeFlaky(MemtableSizeTest.java:149)
	at org.apache.cassandra.Util.runCatchingAssertionError(Util.java:696)
	at org.apache.cassandra.Util.flakyTest(Util.java:721)
	at org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:81)

Based on CASSANDRA-17298 they changed the memtable_allocation_type to heap_buffers (in the unit test).
As a result the test now fails in 4.0 and 4.1. Only the test is broken.

@tilman-aiven tilman-aiven marked this pull request as ready for review June 20, 2024 07:23
@tilman-aiven tilman-aiven marked this pull request as draft June 20, 2024 07:55
@tilman-aiven
Copy link
Author

https://aiven-io.slack.com/archives/C052RDBD1TP/p1718867347237329?thread_ts=1718866820.372779&cid=C052RDBD1TP

  • increase the threshold testSize[skiplist] (org.apache.cassandra.cql3.MemtableSizeTest)

@tilman-aiven
Copy link
Author

tilman-aiven commented Jun 20, 2024 •
edited
Loading

@sjamgade
During the daily the suggestion was to keep the flaky test untouched, as long as we get the build.

The reason why the test fails

  • By default we use heap_buffers in cassandra.yaml, but the unit tests were switched for testing to offheap_objects. This needs to be reverted. We should be testing with heap_buffers on all branches, we do it only in cassandra-3.0 at the moment.
  • It was discovered that unit tests were running with memtable_allocation_type: offheap_objects when we ship C* with heap_buffers.
  • So we changed that in CASSANDRA-19326, now we test with memtable_allocation_type: heap_buffers. As a result, this test now fails all the time on 4.0 and 4.1.

The severity is low (CASSANDRA-17298)
I could successfully build with ant build

@tilman-aiven tilman-aiven marked this pull request as ready for review June 20, 2024 08:55
@tilman-aiven tilman-aiven requested a review from sjamgade June 20, 2024 08:55
sjamgade
sjamgade approved these changes Jun 20, 2024
View reviewed changes
Copy link

@sjamgade sjamgade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjamgade sjamgade merged commit f3f8294 into aiven-4.1.5 Jun 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjamgade sjamgade sjamgade approved these changes

@aris-aiven aris-aiven Awaiting requested review from aris-aiven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tilman-aiven @sjamgade @meatlink