Highlighter highlights all lines inside folded regions

[annikovk]

I have serveral big folded regions (several thousand lines) stay one after another:

Once I search something, highlighter is invoked to highlight all of the found strings: https://github.com/ajaxorg/ace/blob/master/lib/ace/ext/searchbox.js#L266

During the highlighting process, it takes editor's visible rows, and draws single line markers for every found range within visible rows.

So, the problem is the fact that Ace thinks that rows inside folded regions are visible and tries to add markers for all of them:

This causes UI freezes during the search: JetBrains/IntelliJ-Log-Analyzer#11
The only workaround I found is to unfold all regions, which is not acceptable.

[andrewnester]

@annikovk could you please provide a minimal code so we can easier reproduce this issue? Thank you

[annikovk]

1. Open your sample editor (https://ace.c9.io/build/kitchen-sink.html),
2. Enable editor's gutter
3. Search for 'alert' word
4. Collapse the region with 'alert' word in the editor
5. Focus search input to highlight all occurrences of 'alert' word
6. The selected-word node (which highlights 'alert' word) is not removed on code block folding despite the fact it is invisible:

The problem is: in case there are thousands of such nodes collapsed, ace editor freezes.

[annikovk]

@andrewnester have you been able to reproduce that?
Is it a confirmed bug now?

[andrewnester]

@annikovk haven't looked at reproducing it yet, will update once we know the details, but it looks like it should be clear to reproduce

[andrewnester]

@annikovk you mentioned

The only workaround I found is to unfold all regions, which is not acceptable.

How does unfolding help in this case? These selected word elements are still there, right?

[annikovk]

I am trying to eliminate the freeze. And the freeze happens in case there are thousands of selected words inside the folded region, which is inside visible area of the editor

unfolding helps to move selected elements out of visible region, so they are removed from DOM

Let me know if it is needed to describe that in more details with screenshots.

[andrewnester]

Okay, got it!
I guess we indeed should just have 1 selected word dom element when the code is collapsed, there is no need to have them overlap.
I guess the reason we have is not to add / remove dom elements when code folds for performance reasons but it also seems like it already causes performance issues :)

I’ll try to work on PR for this

[andrewnester]

@annikovk could you please check if your issue is solved here? https://raw.githack.com/andrewnester/ace/bug/4687/kitchen-sink.html

[annikovk]

Yes, 100% working as in my dreams. Thank you!

[andrewnester]

We just merged the PR and released new 1.5.2 version containing the fix