fix: Some Python syntax highlight enhancements #4708
Conversation
| regex: "[\\]\\)\\}]" | ||
| regex: "[\\)\\}]" | ||
| }, { | ||
| token: "paren.lbracket", |
There was a problem hiding this comment.
Could you explain why yo want to a new token here? paren.lbracket seems to be some new token you introduced and it won't be styled properly anyway.
There was a problem hiding this comment.
You are right, I have removed these tokens from the pull request.
zardam
force-pushed
the
python_highlight_rules
branch
from
c8e7195 to
fce9a7c
Compare
There was a problem hiding this comment.
Please fix the test here, it should be entity.name.function after your change
https://github.com/ajaxorg/ace/blob/master/lib/ace/mode/_test/tokens_python.json#L336
zardam
force-pushed
the
python_highlight_rules
branch
from
fce9a7c to
8c01a6e
Compare
|
I have updated the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #4708 +/- ##
==========================================
- Coverage 71.19% 71.19% -0.01%
==========================================
Files 553 553
Lines 55598 55598
Branches 10392 10392
==========================================
- Hits 39584 39583 -1
- Misses 16014 16015 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Merged, thanks for the contribution! |
fix: Some Python syntax highlight enhancements:
For example, with dracula theme, before:
After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.