Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identifiers recognition for Rust mode #4868

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Jul 27, 2022

Issue #, if available: #4600

Description of changes:

  1. Rust identifiers recognistion
  2. Generics highlight support
  3. Doc comments support

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mkslanc mkslanc changed the title Fix identifiers recognisition for Rust mode Fix identifiers recognition for Rust mode Jul 27, 2022
@mkslanc mkslanc force-pushed the fix-rust-highlight branch from c8b5ab2 to c37c41c Compare July 27, 2022 11:12
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #4868 (47e84e1) into master (897ee0a) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##           master    #4868   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files         539      539           
  Lines       40625    40627    +2     
  Branches     6420     6420           
=======================================
+ Hits        34837    34840    +3     
+ Misses       5788     5787    -1     
Flag Coverage Δ
unittests 85.75% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mode/rust_highlight_rules.js 52.00% <25.00%> (+8.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkslanc mkslanc marked this pull request as ready for review July 27, 2022 11:19
Copy link
Contributor

@andrewnester andrewnester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkslanc the change looks good but could you please resolve conflicts?

@mkslanc
Copy link
Contributor Author

mkslanc commented Aug 5, 2022

@mkslanc the change looks good but could you please resolve conflicts?

Sure, done!

@mkslanc mkslanc requested a review from andrewnester August 5, 2022 10:00
@andrewnester andrewnester merged commit bbb5800 into ajaxorg:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants