Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybindings: Behavior when assigning Ctrl-S in VSCode keybindings. #5031

Closed
Daru-IBN5100 opened this issue Jan 20, 2023 · 0 comments · Fixed by #5032
Closed

keybindings: Behavior when assigning Ctrl-S in VSCode keybindings. #5031

Daru-IBN5100 opened this issue Jan 20, 2023 · 0 comments · Fixed by #5032
Labels
bug effort/small p2 pr-available

Comments

@Daru-IBN5100
Copy link

Describe the bug

I'm using Ctrl-S with save assigned, but it becomes showKeyboardShortcuts during VSCode keybindings.

Expected Behavior

It should be save.

Current Behavior

It becomes showKeyboardShortcuts.

Reproduction Steps

Ctrl-S key in after set to VSCode keybindings.

Possible Solution

In ace/src/keyboard/vscode.js,

133 bindKey: {mac: "Command-K|Command-S", win: "Ctrl-K|Ctrl-S"},
134 name: "show Keyboard Shortcuts"

is unnecessary.

already

212 bindKey: { mac: "Command-K Command-R|Command-K Command-S", win: "Ctrl-K Ctrl-R|Ctrl-K Ctrl-S" },
213 name: "show Keyboard Shortcuts"

there is.

Additional Information/Context

No response

Ace Version / Browser / OS / Keyboard layout

Ace: 1.14.0 Keyboard layout: US
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug effort/small p2 pr-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove broken keybinding from vscode mode ajaxorg/ace
3 participants
@InspiredGuy @andrewnester @Daru-IBN5100