fix: improve prefixing for inline preview #5439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5439 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 584 584
Lines 46437 46463 +26
Branches 7023 7023
=======================================
+ Hits 40679 40705 +26
Misses 5758 5758
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
oykuyilmaz
reviewed
Dec 29, 2023
| @@ -197,7 +197,14 @@ class Autocomplete { | |||
| } | |||
|
|
|||
| $updateGhostText(completion) { | |||
| var prefix = util.getCompletionPrefix(this.editor); | |||
| // Ghost text can include characters normally not part of the prefix (e.g. whitespace). | |||
There was a problem hiding this comment.
do you know why getCompletionPrefix in utils doesn't consider whitespaces? Should we update that too?
oykuyilmaz
reviewed
Dec 29, 2023
src/autocomplete_test.js
Outdated
| }, 100); | ||
| }, 100); | ||
| }, | ||
| "test: should keep shwoing ghost text when typing ahead with whitespace": function(done) { |
oykuyilmaz
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: NA
Description of changes: Use the string of text between the start of the autocomplete prefix and the current cursor position, regardless of the characters in between, to determine whether inline preview should be rendered. This allows inline preview to stay visible when typing ahead with whitespace.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.