Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide gutter tooltip event missing from editor signal #5701

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

nlujjawal
Copy link
Contributor

Description of changes:
hide gutter tooltip event is not getting fired from editor signal in case when the cursor moves to a non-active gutter row which hides the active gutter tooltip.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

@nlujjawal nlujjawal force-pushed the fix_gutter_tooltip branch 2 times, most recently from a9d7827 to 4276144 Compare December 20, 2024 15:45
@nlujjawal nlujjawal merged commit 66a6736 into master Dec 20, 2024
1 check passed
@nlujjawal nlujjawal deleted the fix_gutter_tooltip branch December 20, 2024 16:11
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.02%. Comparing base (713abb6) to head (4a04740).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/mouse/default_gutter_handler.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5701      +/-   ##
==========================================
- Coverage   87.02%   87.02%   -0.01%     
==========================================
  Files         598      598              
  Lines       43588    43590       +2     
  Branches     7162     7163       +1     
==========================================
+ Hits        37932    37933       +1     
- Misses       5656     5657       +1     
Flag Coverage Δ
unittests 87.02% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants