Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unicode title caching #3

Open
ajayyy opened this issue Jun 12, 2023 · 1 comment · May be fixed by #9
Open

Support unicode title caching #3

ajayyy opened this issue Jun 12, 2023 · 1 comment · May be fixed by #9

Comments

@ajayyy
Copy link
Owner

ajayyy commented Jun 12, 2023

Right now it just doesn't serve them d42885a
@mini-bomba
Copy link
Contributor

Idea: json.dumps() has a ensure_ascii option (true by default) - just serialize all titles as a json string before sending
Dearrow could check if the header value deserializes into a json string - otherwise treat the header as a raw string (for backwards compatibility, not sure if we'd actually need it as there aren't many instances right now)

This was referenced Jul 13, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Encode title as JSON to bypass ASCII header limitations mini-bomba/DeArrowThumbnailCache
2 participants
@ajayyy @mini-bomba