Semi-related: #96

Yeah, probably. This is a bit more fleshed out and dedicated to one feature. A good format for a GitHub issue, I'd imagine.

Yep, just want to link previous discussion

Well, what do you think?

:(

I definitely think this is a cool idea, but it may probably is a little out of scope right now. Maybe as a long term goal.

Now that SponsorBlock is old, it does have many people with high reputation, so "dangerous" features like this and #409 can be limited to only those with very high reputation

To work best, they would probably have to be replaced with an image, not just a shape, but that might be too much work to be viable.

Some way to have the "annotations" move smoothly across the screen over time might be needed as well.

So far I've submitted 156 segments and saved others about 60 hours. Does that count as high reputation? "Very high reputation" worries me, I wouldn't set the bar too high. I've been submitting segments for about a month so far, on pretty much every video I watch.

To work best, they would probably have to be replaced with an image, not just a shape, but that might be too much work to be viable.

Instead of specifying a solid color, you could have the extension take a screenshot of that portion of the video, and display it for the duration of the visual segment. It's easily something that could happen in an update, rather than on first release.

Some way to have the "annotations" move smoothly across the screen over time might be needed as well.

Careful with this. I intentionally kept this as primitive as possible, to hopefully prevent revealing more than necessary about the underlying distraction.

This is one of the only extensions to the idea I would theoretically approve of (if I were the one calling the shots, which I'm not), but again like other aspects of the 'plotter' the way this would be presented to the editor is completely undefined. You could implement an entire keyframe system, or just have a start and end point and an animation curve (probably the way I would do it). Allow the curve to be edited manually, but provide a couple presets. This adds additional complexity, beware.

Of course, this obstruction system doesn't even touch things like sound effects... but it would be much more trouble than it's worth to try to hammer out a solution to somehow lessen that without affecting the surrounding audio in a negative way. It would also require SponsorBlock to start processing all audio which comes out of the player which is probably even more complicated than visual segments would be. Mute segments are mildly less complex than that, but still not optimal.

Finding the optimal solution is most likely not possible, and like the rest of SponsorBlock, a compromise needs to be found.

Keep in mind that once most of the concerns are worked out, since I'm a programmer myself I could look into implementing this all as a pull request. I just don't want to put work into a plotter that you don't like, or an animation system that you don't like.

I agree with your comment about audio, I don't think that is something feasible, especially with just a browser extension.

I feel like this may be useful getting the opinions of others on this. Should I make a channel/room on Discord/Matrix to discuss this?

Also, on the example link you showed in the first post, I'm not sure just covering it with a screenshot of the video will help much.

I feel like this may be useful getting the opinions of others on this. Should I make a channel/room on Discord/Matrix to discuss this?

Sure.

Also, on the example link you showed in the first post, I'm not sure just covering it with a screenshot of the video will help much.

It also won't help much to ask users to invent their own image to overlay. Not to mention the abuse that could bring.

You'd also either have to store every image that they upload, or have their computer make requests to an arbitrary url (BAD BAD BAD BAD), or proxy it through your backend (less bad but still dangerous)

You'd also either have to store every image that they upload, or have their computer make requests to an arbitrary url (BAD BAD BAD BAD), or proxy it through your backend (less bad but still dangerous)

While anonymous image upload is scary, I'm not sure if there is another viable way. We've already experienced severe ratelimiting just downloading captions for use with https://github.com/andrewzlee/NeuralBlock and had to shut it down until we find another solution.

I doubt we would be able to download videos on the server to be able to take screenshots server-side, they would have to be done client side.

Could you send an example of what you think the example video should look like to hide the obstructions?

While anonymous image upload is scary, I'm not sure if another viable way.

You could not have users provide custom images? That's kind of what I was hinting at in my comment.

I doubt we would be able to download videos on the server to be able to take screenshots server-side, they would have to be done client side.

That's not at all what I mean. The client is already playing the video, so when a visual segment is encountered they could just display a portion of the frame that it started on, on top of the video until the segment is over.

It's hard to explain over text, but let me try to show what I mean.

Control
Solid color
Persist

This is not a job for the server anyway. The server should only store data about the shape of the obstruction.

This could be what you were thinking of when you said "custom images". As a plus, the server does not have to do any extra work, and you don't have to think about image uploads. You do have to work out how to display that, though... possibly problems when you skip to the middle of a visual segment and the client does not have that frame in memory. You might just have to use black in that case.

I see, that makes more sense than what I was thinking...

Slight downside: people may think it's an encoding/compression issue, or the fault of YouTube/the creator. It looks a lot like an artifact.

Yes, I'm not sure if it really looks any better than without it being covered, but it would make sense for banner ads.

Well, for me, I'd gladly sacrifice FMV in that one area just to avoid seeing that like button. I don't know if you know this (or if everyone does), but things like this absolutely piss me off when I see them in a YouTube video. Sure, using SponsorBlock to attempt to skip it (which I have done for that particular video; here) is a fine solution... in the one case where the entirety of its screen time is spent saying "wow" and "ooh" and "so cool", basically unimportant to the video, and not even missed (or noticed) when it's skipped over.

That image I posted up above (the red "BE SURE TO SUBSCRIBE") happens during the video introduction, which is important content that can not be skipped over. That is where visual segments will shine. Maybe it does count as a banner ad; not sure what your definition is.

As said up above, once the details are worked out, I will happily produce code towards an implementation because of how strongly I feel about this. SponsorBlock is absolutely invaluable, THANK YOU for making YouTube more bearable. (And for letting me take out my anger by making perfectly-timed segments to skip over the offending content, rather than disliking the video and yelling in the comments section.)

While you might implement it now, it still has to be maintained long-term, so we still have to make sure it's useful.

I guess we'd not use the same category system for this. This one probably only needs sponsor, self promo, and interaction.

Maybe it does count as a banner ad; not sure what your definition is

I was referring to actual ads (sponsor)

That might be a good idea. The current category system only deals with time-skipping segments, but these ones aren't meant to be skipped (in fact, they're an indication that the section IS important and CAN'T be skipped, but there is something annoying on-screen), so it could be a different API that clients (like the extension) can opt-into by manually retrieving the data.

While you might implement it now, it still has to be maintained long-term, so we still have to make sure it's useful.

That's true. Additional reasons to keep it around are always welcome. I believe I've made a good case for it so far, as long as the implementation details (which haven't entirely been decided yet) turn out well.

I made the channel as #visual-overlay-discussion. Matrix / Discord

UI idea: Add a visual option to the category selector in the submission notice. When selected, an extra option will appear allowing x and y to be selected.

an extra option will appear allowing x and y to be selected.

I'd prefer for it to be a little more like ShareX's region select, where you can click and drag over the video to draw your shape, and tweak it afterwards with movement/resize handles. Unless that's what you mean by x and y...

I very often use YouTube in audio only mode and like small and focused plugins. A feature like this definitely bloats my favorite plugin, brings no value and fits nicely into a separate dedicated plugin. Please do not include it in SponsorBlock.

I very often use YouTube in audio only mode and like small and focused plugins. A feature like this definitely bloats my favorite plugin, brings no value and fits nicely into a separate dedicated plugin. Please do not include it in SponsorBlock.

SponsorBlock's purpose extends past podcasts and music videos. I also use YouTube in the background, but I mainly use it when watching visual content.

bloats my favorite plugin, brings no value and fits nicely into a separate dedicated plugin

Bloat: Only slightly.

Brings no value: If you're not watching the video, then visual segments have no use for you, of course. Mute segments don't either because the visual information those mean to preserve aren't being consumed by you, so they may as well just be skipped.

Fits nicely into a separate dedicated plugin: Meh. SponsorBlock has the database, infrastructure and community to ensure that this sort of thing would gain traction, but other projects don't. If I were to code all this up myself into a new extension for example, noone would use it.

SponsorBlock has the database, infrastructure and community to ensure that this sort of thing would gain traction, but other projects don't. If I were to code all this up myself into a new extension for example, noone would use it.

Another plugin could share infrastructure and community if not database.

Blocking visual sponsors is useless without also being able to auto-skip, so would not make sense as a dedicated plugin.

Instead of a solid color shape or an image covering I think a blur type effect where the colours are sampled from just outside the bounding box of the trinket would look pretty seamless most of the time. Would definitely be a bit harder to implement and would also have to account for any of the edges of the bounding box being on the edge of the video though.

a blur type effect where the colours are sampled from just outside the bounding box of the trinket would look pretty seamless most of the time

So like that tunnel filter, but reversed?

Sorry I'm not familiar with effect of a tunnel filter. Instead of sampling the pixels directly behind the blur filter like you would typically expect you sample the pixels around the edge of the bounding box to be blurred.

A very crude implementation could be as simple as this: say you have the bounding box of a trinket which is 100px vertically. You take a 50px vertically above and below the trinket then append the images together then blur that new image and apply it over the trinket.

Hope that makes the basic idea clear.

Sorry I'm not familiar with effect of a tunnel filter. Instead of sampling the pixels directly behind the blur filter like you would typically expect you sample the pixels around the edge of the bounding box to be blurred.

A very crude implementation could be as simple as this: say you have the bounding box of a trinket which is 100px vertically. You take a 50px vertically above and below the trinket then append the images together then blur that new image and apply it over the trinket.

Hope that makes the basic idea clear.

Photo Booth (Apple program) has a filter that basically only reveals a circle, and then stretches out the edges of the circle to fill the entire rest of the image. Reversed, that would be filling in a circle by stretching its edges inward.

Photo Booth (Apple program) has a filter that basically only reveals a circle, and then stretches out the edges of the circle to fill the entire rest of the image. Reversed, that would be filling in a circle by stretching its edges inward.

Yes this sounds right!

A priority list to make the first implementation less over-complex:

Priorities: Focus on fixing transitions > covering logos/icons. Simpler problem with a more clear goal, can easily be extended to logo covering.

• Full freeze frame segment (keep the frame from start to end)
• Toggle to take the freeze frame from the start of last non skipped area (this would help fix transitions out of sponsors, keep the before sponsor frame)

• Solid colour frame instead of freeze frame
• Fade in and fade out toggle (for fade in + hold, two segments can be made, a solid colour fade in and solid colour non fade)

• Rectangular select where the freeze frame should be

More out there stuff reserved for a later time:

• Take frames from arbitrary points of the video
• Animated shape overlays (as in, the shape slowly moves over the course of the segment)
• Arbitrary shapes
• Modifying frames using effects/blurs
• Replacement images/video

I have a working demo with a copied 2D canvas in the discord

• freeze frame
  • pull a certain frame natively and repeat that image on the canvas
  • add external overlay to combine to that canvas
• solid colour freeze frame / rectangular select
  • just load external svg and draw it on the canvas (can also just draw 2d shapes)

latency

unfortunately there is latency associated with it, the refresh rate is tied to the draw interval. The lower the draw interval, the higher the memory/cpu usage, naturally. Ideally it would be synced to the video but when set up to integers, there can be desync up to 3 frames just because of frame timings. At best there is 1 process time of delay, which might be mitigated at running at 2x refresh rate

I remember seeing a demo in one of the old links I posted where you can grab the video frame early to defeat the latency. double buffering