This repository has been archived by the owner on Dec 31, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 93
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(deploy): Fixed deploy callbacks launching order
The issue was, that all driver callbacks (i.e. invoked from deploy_before_restart, deploy_after_restart etc. methods) were launched after deploy was completely finished (instead at proper callback time). However `deploy/after_restart.rb` etc. callbacks from projects were launched during callback phase. This could lead to the problems, for example: `deploy/after_restart.rb` might be dependant on `deploy_before_restart` action from the drivers and would crash if not fullified. Up to this commit, this would happend. However this fix ensures, that both driver and app callbacks are launched at the same time (first drivers, then app). It was resolved, by setting correct context to the drivers. When driver is in "callback phase" it expects a "callback context", otherwise it would assume, that action is fired up in deploy recipe context, and thus - move it down to the queue.
- Loading branch information
Showing
3 changed files
with
18 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters