Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests due to refactor of PandocUtils.hs/Pandoc.hs #3

Open
ajkavanagh opened this issue Feb 14, 2021 · 0 comments
Open

Fix broken tests due to refactor of PandocUtils.hs/Pandoc.hs #3

ajkavanagh opened this issue Feb 14, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@ajkavanagh
Copy link
Owner

The tests for links are broken due to a refactor of code from PandocUtils.hs to Pandoc.hs. This was due to the link re-writing code needing access to the Polysemy monad and thus being moved. This now means that the tests will essentially be broken as there (shouldn't be) any code for them to access. If they work, then there is code that is not longer being used.

Main things to do:

  • Remove unused code from PandocUtils.hs
  • Rewrite the tests to use Pandoc.hs monad equivalent functions, and test using a Polysemy monad.

Tests are broken:

processPandocLinksSpecs
  Should ignore no links at all FAILED [1]

Failures:

  test/Lib/PandocUtilsSpecs.hs:126:20:
  1) processPandocLinksSpecs Should ignore no links at all
       uncaught exception: ErrorCall
       Prelude.undefined
       CallStack (from HasCallStack):
         error, called at libraries/base/GHC/Err.hs:80:14 in base:GHC.Err
         undefined, called at test/Lib/PandocUtilsSpecs.hs:126:20 in main:Lib.PandocUtilsSpecs
@ajkavanagh ajkavanagh added the bug Something isn't working label Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant