Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Favicon does not rednder #1676

Closed
4 tasks done
TuftyBruno opened this issue Nov 18, 2023 · 11 comments · Fixed by #2052
Closed
4 tasks done

Custom Favicon does not rednder #1676

TuftyBruno opened this issue Nov 18, 2023 · 11 comments · Fixed by #2052
Assignees
Labels
🐛 Bug Something isn't working

Comments

@TuftyBruno
Copy link

Environment

Docker

Version

No response

Describe the problem

Favicon does not change with any link or even local source.

Per Manicraft1001 on Discord: The BoardHeadOverride component does in fact not override the CommonHead compontent.

Logs

No response

Context

No response

Please tick the boxes

  • I confirm that I attached the proper logs
  • I've read the docs
  • I've checked for duplicate issues
  • I've tried to debug myself
@TuftyBruno TuftyBruno added the 🐛 Bug Something isn't working label Nov 18, 2023
@KhyHolyDragon
Copy link

yes.i also have the same issue.
I tried to change the icon which in imgs files. but it also doesn't work.
The files which in imgs folder cannot be changed.

@mritd
Copy link

mritd commented Dec 28, 2023

same issue

@fuzzzor
Copy link

fuzzzor commented Feb 18, 2024

same issue for me too

@PilaScat
Copy link

PilaScat commented Mar 1, 2024

up

@JSylvia007
Copy link

Phew! I thought I was doing something wrong. Glad it's an actual bug! Other than this, Homarr is AWESOME!

@ZD-FLoM
Copy link

ZD-FLoM commented Mar 17, 2024

I have tried local and remote images, same issue. Favicon does not change when setting to custom icon.

@foresterfx
Copy link

foresterfx commented Mar 23, 2024

I accomplished this via a work around for anyone that cares. On unraid, I'm able to easily access the app data, so I put my custom favicon icons (favicon.png, favicon.svg, favicon-squared.png) in the icons folder. Any folder that is accessible from within the docker container would work fine. I'm sure uploading icons the traditional way would work too.

Then I just moved the files to the imgs folder via docker exec, then reboot my container and it worked. Probably have to do this each time the container gets an update until this issue is fixed. You will likely have to clear your cache on your browser too.

The favicons are stored in a folder in the docker container at this path: public/imgs/favicon.

This is the basic form of docker exec:
docker exec my_container mv usr/src/app/old_folder/file.txt usr/src/app/new_folder/

docker exec homarr mv public/icons/favicon.png public/imgs/favicon
docker exec homarr mv public/icons/favicon-squared.png public/imgs/favicon
docker exec homarr mv public/icons/favicon.svg public/imgs/favicon

@JSylvia007
Copy link

I accomplished this via a work around for anyone that cares. On unraid, I'm able to easily access the app data, so I put my custom favicon icons (favicon.png, favicon.svg, favicon-squared.png) in the icons folder. Any folder that is accessible from within the docker container would work fine. I'm sure uploading icons the traditional way would work too.

Then I just moved the files to the imgs folder via docker exec, then reboot my container and it worked. Probably have to do this each time the container gets an update until this issue is fixed. You will likely have to clear your cache on your browser too.

The favicons are stored in a folder in the docker container at this path: public/imgs/favicon.

This is the basic form of docker exec: docker exec my_container mv usr/src/app/old_folder/file.txt usr/src/app/new_folder/

docker exec homarr mv public/icons/favicon.png public/imgs/favicon
docker exec homarr mv public/icons/favicon-squared.png public/imgs/favicon
docker exec homarr mv public/icons/favicon.svg public/imgs/favicon

I tried this myself before and I couldn't get it to work reliably. I can access the favicon, but it still shows the wrong one. I've even tried different computers and browsers.

@joobert
Copy link

joobert commented May 13, 2024

Bump. Can't get this to work

@manuel-rw manuel-rw self-assigned this May 13, 2024
@ajnart ajnart self-assigned this May 15, 2024
@ajnart ajnart linked a pull request May 15, 2024 that will close this issue
@ajnart
Copy link
Owner

ajnart commented May 16, 2024

Will be released in the next version! You can already test if the behavior is fixed using the dev image ! Feel free to ping me if it is not fixed on your end ;)

@thiago021
Copy link

Up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.