fix: allow readonly arrays in interfaces #1448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, a readonly array would be inferred as "object":
Now this is properly inferred as "array".
What issue does this pull request resolve?
#1447
What changes did you make?
Changed
T extends any[]
toT extends readonly any[]
. This works sincereadonly T[]
is a subset ofT[]
, and thusT[]
always satisfiesreadonly T[]
.Is there anything that requires more attention while reviewing?
The one word changed 😄