Remove methods without cancellation token parameters from (I)HaveIBeenPwnedClient #66
Labels
Announcement
BREAKING CHANGE
Breaking change that involves increasing the major version number
enhancement
New feature or request
Milestone
(Related: #65)
In V6, all public methods in HaveIBeenPwnedClient have two versions: One with a CancellationToken and one without. In the modern .NET world, there's a big push to either requiring cancellation tokens (or a explicit CancellationToken.None when cancelling is not important) or have an optional parameter with the cancellation token with a default value.
I prefer being as explicit in code as possible so in #65 we already marked the methods without a
CancellationToken
with anObsoleteAttribute
. In vFuture, we remove the methods without a cancellation token.The text was updated successfully, but these errors were encountered: