Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove methods without cancellation token parameters from (I)HaveIBeenPwnedClient #66

Open
akamsteeg opened this issue Jun 25, 2022 · 0 comments
Labels
Announcement BREAKING CHANGE Breaking change that involves increasing the major version number enhancement New feature or request
Milestone

Comments

@akamsteeg
Copy link
Owner

akamsteeg commented Jun 25, 2022

(Related: #65)

In V6, all public methods in HaveIBeenPwnedClient have two versions: One with a CancellationToken and one without. In the modern .NET world, there's a big push to either requiring cancellation tokens (or a explicit CancellationToken.None when cancelling is not important) or have an optional parameter with the cancellation token with a default value.

I prefer being as explicit in code as possible so in #65 we already marked the methods without a CancellationToken with an ObsoleteAttribute. In vFuture, we remove the methods without a cancellation token.

@akamsteeg akamsteeg added enhancement New feature or request BREAKING CHANGE Breaking change that involves increasing the major version number labels Jun 25, 2022
@akamsteeg akamsteeg added this to the 7.x milestone Jun 25, 2022
@akamsteeg akamsteeg modified the milestones: 7.x, vFuture Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Announcement BREAKING CHANGE Breaking change that involves increasing the major version number enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant