Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

Automatically activate valid certificates if available #62

Open
jtary opened this issue Mar 9, 2023 · 5 comments
Open

Automatically activate valid certificates if available #62

jtary opened this issue Mar 9, 2023 · 5 comments
Assignees
Labels
bug Something isn't working sev2

Comments

@jtary
Copy link
Contributor

jtary commented Mar 9, 2023

Describe the bug
Currently, it's possible for the active certificate to be invalid, while having other valid certificates available. These can be activated from the settings page, but this is unintuitive. I would be much better UX for the active certificate to be updated automatically to a valid cert if one is available.

The bug aspect of this is the many ways in which a user can be told they have a valid cert, when they don't, or vice-versa.

Additional context
Currently the active cert is stored in an atom. This should be changed to a getter function that returns a cached value, and can update the value if it's appropriate to do so.

Note: This change would have require significant re-work of the various pages that use the certificate, so it could be time consuming and has a higher risk of introducing regressions. Time for development and testing should be planned accordingly.

@jtary jtary added bug Something isn't working sev2 and removed product/console labels Mar 9, 2023
@yshsaxena
Copy link
Contributor

Hi @jtary and @anilmurty, wanted to take this up!!

@anilmurty
Copy link
Contributor

Thanks @yshsaxena - please go ahead!

@yshsaxena
Copy link
Contributor

yshsaxena commented Apr 13, 2023

hi @jtary, is only one cert can remain active at a time?

Screenshot 2023-04-13 223212

@anilmurty
Copy link
Contributor

anilmurty commented Apr 13, 2023

@yshsaxena - correct. so yes, it's a bug that it is allowing more than one to be activated. Good catch :)

@anilmurty
Copy link
Contributor

Hi @yshsaxena - are you still working on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working sev2
Projects
None yet
Development

No branches or pull requests

3 participants