Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue with image loading in darklaf. #854

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

tychobrailleur
Copy link
Collaborator

  1. changes proposed in this pull request:

Explicitly retrieve image when darklaf is used, as image only gets loaded after interacting with UI.

  1. changelog and release_notes ...
  • have been updated
  • do not require update
  1. [Optional] suggested person to review this PR @akasolace

@akasolace
Copy link
Collaborator

@tychobrailleur is this only a bug in darklaf ? I am not sure but I thought I experienced the same behaviour in Nimbus ...

@tychobrailleur
Copy link
Collaborator Author

I could not reproduce on Nimbus, it only seemed to happen on darklaf themes for me.

@akasolace
Copy link
Collaborator

I could not reproduce on Nimbus, it only seemed to happen on darklaf themes for me.

ok

@weisJ I cc you to keep you informed of that issue

@akasolace akasolace merged commit 2b99dc0 into ho-dev:master Jan 18, 2021
@tychobrailleur
Copy link
Collaborator Author

Did it fix the issue for you, @akasolace ?

@akasolace
Copy link
Collaborator

@tychobrailleur tbh, I did not try it yet. I will do that as soon as I rebase my branch (today or tomorrow) ....

@akasolace
Copy link
Collaborator

@tychobrailleur so I tested it yesterday and it has been fixed in one place but not in the other.
I will share animated gif this evening to make it clearer but the situation is that:

  • clock icon now appears correctly from the start
  • club logo: the default icon which is loaded by the problematic function, only appears after interaction (mouse hover)

@tychobrailleur
Copy link
Collaborator Author

@tychobrailleur so I tested it yesterday and it has been fixed in one place but not in the other.

Ah, yes, I can imagine as I didn't look at the other one. I'll amend the PR.

@weisJ
Copy link
Contributor

weisJ commented Jan 23, 2021

This problem should be fixed in the darklaf latest.intergration version. Because darklaf uses caching and lazy evaluation for derived images (i.e. they are only loaded when needed and share the same original image for optimal quality) sometimes the images could not be available when painting as AWT loads images asynchronously.

@akasolace
Copy link
Collaborator

akasolace commented Jan 24, 2021

@weisJ ok good to know this will be fixed upstream. Meanwhile @tychobrailleur found a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants