Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htop background issues #46

Closed
deadtrickster opened this issue Dec 13, 2018 · 17 comments
Closed

htop background issues #46

deadtrickster opened this issue Dec 13, 2018 · 17 comments

Comments

@deadtrickster
Copy link

As requested, emacs -Q screenshot:

screenshot_2018-12-13_09-29-48

@deadtrickster
Copy link
Author

emacs is the HEAD of master

@deadtrickster
Copy link
Author

maybe related (git diff):

screenshot_2019-01-02_15-27-01

also interesting to note - emacs string face used. They should be white. Maybe this conflicts with escape codes. Ansi-term is ok.

@deb0ch
Copy link
Contributor

deb0ch commented Jan 2, 2019

One more info that would be useful: what version/commit of emacs-libvterm are you using?

@deadtrickster
Copy link
Author

1b03e4e

@deadtrickster
Copy link
Author

strings highlighting can be turned of by (setq-local font-lock-keywords-only t) in the mode hook.

@akermu
Copy link
Owner

akermu commented Jan 22, 2019

@deadtrickster Is it possible to give me a short elisp configuration loaded with emacs -Q, which reproduces the issue?

@deadtrickster
Copy link
Author

Yeah, will do on weekend.

@deadtrickster
Copy link
Author

I can reproduce it with emacs -Q and two lines:

(add-to-list 'load-path "../emacs-libvterm") 
(require 'vterm)

@akermu
Copy link
Owner

akermu commented Jan 27, 2019

I cannot reproduce this here, but I pushed a update regarding color handling in general. So can you reproduce this with the latest master? And which OS are you using, it might be related to the version of libvterm?

@deadtrickster
Copy link
Author

I have latest ubuntu here.

htop inside xfce4-terminal:

screenshot_2019-01-27_19-28-54

htop inside emacs:

screenshot_2019-01-27_19-32-18

Same color schema. I would say black background handling is suspicious.

@deadtrickster
Copy link
Author

to rule out htop-specific glitches I tried scripts from this page:
http://www.lihaoyi.com/post/BuildyourownCommandLinewithANSIescapecodes.html#background-colors

Black and magenta backgrounds seem to be off

@akermu
Copy link
Owner

akermu commented Jan 28, 2019

With 920d847 the script prints now the correct colors. Does this fix your issue?

@deadtrickster
Copy link
Author

I rebuilt emacs, libterm, now buffer background is always black, and still colors messed up in htop and scripts :-)
screenshot_2019-01-29_13-32-02

@deadtrickster
Copy link
Author

deadtrickster commented Jan 29, 2019

Actually black background is ok, not magenta though:
screenshot_2019-01-29_13-39-08

Note how setting background to magenta cleared black background to default-bg and set magenta as foreground.

@akermu
Copy link
Owner

akermu commented Jan 29, 2019

Magenta is fixed with 622cde3. The htop background issue seems to be a different issue.

@akermu
Copy link
Owner

akermu commented Aug 3, 2019

@deadtrickster Is this still reproduceable with the latest master, since #82 is merged?

@deadtrickster
Copy link
Author

nope, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants