Value changed triggered only on control change #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this control behaves differently to default iOS controls such as UISlider. When AXRatingView value is set from code it will currently trigger UIControlEventValueChanged; this is not how UISlider works. UISlider will only trigger value changed event when user interacts with the control to change its value. UIControl class reference documentation states the following. "UIControlEventValueChanged: A touch dragging or otherwise manipulating a control, causing it to emit a series of different values." This commit ensures that UIControlEventValueChanged is only triggered when the value is changed through user interaction. Also given the potential to break backwards compatibility for some users, if you choose to accept this change it should probably be part of a minor release and not a dot release.
akiroom
pushed a commit
that referenced
this pull request
Oct 16, 2014
Value changed triggered only on control change
|
Thank you for your pull request and a kindly words.
You are right. I think it is good opportunity to release ver 1.0.0. I will do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this control behaves differently to default iOS controls such as UISlider. When AXRatingView value is set from code it will currently trigger UIControlEventValueChanged; this is not how UISlider works.
UISlider will only trigger value changed event when user interacts with the control to change its value.
UIControl class reference documentation states the following.
"UIControlEventValueChanged: A touch dragging or otherwise manipulating a control, causing it to emit a series of different values."
This commit ensures that UIControlEventValueChanged is only triggered when the value is changed through user interaction.
Also given the potential to break backwards compatibility for some users, if you choose to accept this change it should probably be part of a minor release and not a dot release.