-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google PubSub gRPC and BigQuery Storage: Akka gRPC 2.1.4 #2678
Google PubSub gRPC and BigQuery Storage: Akka gRPC 2.1.4 #2678
Conversation
72d9ede
to
f43808b
Compare
Thank you, this is an important update. But the breaking changes from ScalaPB are a bit scary to push into a point release, as it upgrades ScalaPB and Akka HTTP. |
In #2613 (comment) @seglo mentioned that
This update seems like it could be a good reason, along with the ability to make several other breaking changes (including to this module) that would complete the migration of all Google modules to |
Yes, it's not ideal, even if it'd only affect users of |
Thanks for your input @armanbilge. We decided to postpone this update and will try to schedule another major release later in 2021. |
Let's bring this PR back to live now! |
I just merged the upgrade to Akka HTTP 10.2.9 with #2820 |
f43808b
to
25bb7e5
Compare
Rebased on current master. |
What is breaking this build is the Furthermore, it looks like I don't have much time to spend on this, so please help out. |
3b2d56f
to
741db0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks! 😁 |
No description provided.