Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google PubSub gRPC and BigQuery Storage: Akka gRPC 2.1.4 #2678

Merged
merged 5 commits into from
Apr 13, 2022

Conversation

raboof
Copy link
Member

@raboof raboof commented May 25, 2021

No description provided.

@probot-autolabeler probot-autolabeler bot added the dependency-change For PRs changing the version of a dependency. label May 25, 2021
@raboof raboof marked this pull request as draft May 25, 2021 13:54
@raboof raboof force-pushed the google-pub-sub-grpc-akka-grpc-2.0.0 branch from 72d9ede to f43808b Compare May 26, 2021 09:47
@raboof raboof marked this pull request as ready for review May 26, 2021 09:52
@ennru
Copy link
Member

ennru commented May 29, 2021

Thank you, this is an important update. But the breaking changes from ScalaPB are a bit scary to push into a point release, as it upgrades ScalaPB and Akka HTTP.
The only excuse would be that Alpakka 3.0.0 is effectively broken as of #2680.

@armanbilge
Copy link
Contributor

armanbilge commented May 30, 2021

In #2613 (comment) @seglo mentioned that

Alpakka major releases don't have to be as rare as they are right now. If there's a good reason (and maybe this is one of them) then we could release an Alpakka 4.0.0 in a more reasonable interval, maybe after 3 months?

This update seems like it could be a good reason, along with the ability to make several other breaking changes (including to this module) that would complete the migration of all Google modules to google-common introduced in #2613. For example, google-pub-sub-grpc also currently has a vestigial dependency to the massive google-auth-library-oauth2-http although it is not used by the internal API (all auth runs through google-common now).

@raboof
Copy link
Member Author

raboof commented May 31, 2021

Thank you, this is an important update. But the breaking changes from ScalaPB are a bit scary to push into a point release, as it upgrades ScalaPB and Akka HTTP.

The only excuse would be that Alpakka 3.0.0 is effectively broken as of #2680.

Yes, it's not ideal, even if it'd only affect users of akka-grpc-pub-sub-grpc that are already on 3.0.0 and use transitive dependencies that are on an older version of Akka gRPC. Without this change there is no version of akka-grpc-pub-sub-grpc that can coexist with Akka gRPC 2.0.0, which is not great either.

@ennru
Copy link
Member

ennru commented Jun 2, 2021

Thanks for your input @armanbilge.

We decided to postpone this update and will try to schedule another major release later in 2021.

@ennru
Copy link
Member

ennru commented Jan 16, 2022

Let's bring this PR back to live now!

@ennru ennru mentioned this pull request Feb 22, 2022
@ennru
Copy link
Member

ennru commented Mar 9, 2022

I just merged the upgrade to Akka HTTP 10.2.9 with #2820

@ennru ennru mentioned this pull request Mar 11, 2022
@ennru ennru force-pushed the google-pub-sub-grpc-akka-grpc-2.0.0 branch from f43808b to 25bb7e5 Compare March 11, 2022 10:44
@ennru
Copy link
Member

ennru commented Mar 11, 2022

Rebased on current master.

@ennru
Copy link
Member

ennru commented Apr 11, 2022

What is breaking this build is the BigQueryMockServer which relies on the Akka gRPC generated power APIs for the server-side. Those APIs changed since Akka gRPC 1.0 and need to be updated for the new style.

Furthermore, it looks like Test / akkaGrpcGeneratedSources := Seq(AkkaGrpc.Server) doesn't kick in to generate the server code only for testing.

I don't have much time to spend on this, so please help out.

@ennru ennru changed the title google-pub-sub-grpc: Akka gRPC 2.0.0 google-pub-sub-grpc: Akka gRPC 2.1.3 Apr 11, 2022
@raboof raboof force-pushed the google-pub-sub-grpc-akka-grpc-2.0.0 branch from 3b2d56f to 741db0d Compare April 12, 2022 14:10
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru changed the title google-pub-sub-grpc: Akka gRPC 2.1.3 google-pub-sub-grpc: Akka gRPC 2.1.4 Apr 13, 2022
@ennru ennru changed the title google-pub-sub-grpc: Akka gRPC 2.1.4 google-pub-sub-grpc and others: Akka gRPC 2.1.4 Apr 13, 2022
@ennru ennru changed the title google-pub-sub-grpc and others: Akka gRPC 2.1.4 google-pub-sub-grpc and BigQuery Storage: Akka gRPC 2.1.4 Apr 13, 2022
@ennru ennru changed the title google-pub-sub-grpc and BigQuery Storage: Akka gRPC 2.1.4 Google PubSub gRPC and BigQuery Storage: Akka gRPC 2.1.4 Apr 13, 2022
@ennru ennru merged commit 7b38664 into akka:master Apr 13, 2022
@seglo
Copy link
Member

seglo commented Apr 16, 2022

Thanks! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants