Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3: Minor cleanups #2740

Merged
merged 2 commits into from
Oct 4, 2021
Merged

S3: Minor cleanups #2740

merged 2 commits into from
Oct 4, 2021

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Oct 2, 2021 •
edited
Loading

This PR does some minor cleanups which are self explanatory (see the commit messages).

@mdedetrich mdedetrich force-pushed the minor-cleanups branch 2 times, most recently from 693ccd3 to 527f57a Compare October 2, 2021 08:35
ennru
ennru approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, it is important keep after the small things.
LGTM.

@ennru ennru added this to the 3.0.4 milestone Oct 4, 2021
@ennru ennru changed the title Minor cleanups S3: Minor cleanups Oct 4, 2021
@ennru ennru merged commit 8fb1287 into akka:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:aws-s3
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mdedetrich @ennru