S3: Allow bucket creation besides us-east-1
for AWS
#2742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be another inconsistency between real AWS and Minio wrt creating a bucket in the non default region (i.e.
us-east-1
). With AWS S3 you need an addition XML payload (along with the host/access-style which typically contains the region) in order to create a bucket in a non defaultus-east-1
region, with Minio this payload is not required. If the XML payload is not in the make bucket request on AWS you will get the following errorFor more details you can read https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateBucket.html , there is already an existing issue at aws/aws-cli#2603 (comment) which demonstrates the same problem (i.e. even with the aws cli you need to provide an additional
LocationConstraint
).A test is provided but do note the fixes on this PR are only verifiable when running the test against
AWSS3IntegrationSpec
. WithMinioS3IntegrationSpec
you won't notice any difference.