Kinesis: clean up contexts in kinesisFlowWithContext on failure #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the binary compatibility failed, maybe someone could give some pointers? |
ennru
reviewed
Feb 2, 2022
kinesis/src/main/scala/akka/stream/alpakka/kinesis/scaladsl/KinesisFlow.scala
Outdated
Show resolved
Hide resolved
hagerf
force-pushed
the
kinesisflow-context-cleanup
branch
from
d9b7ce9
to
e4dbeab
Compare
hagerf
force-pushed
the
kinesisflow-context-cleanup
branch
from
e4dbeab
to
521b1b5
Compare
ennru
changed the title
|
Thank you! |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is one possibility for solving contexts that need handling when writing to a Kinesis data stream fails
References #2814