Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqsPublishFlow.batch never sets delay seconds to SendMessageBatchRequestEntry #3235

Closed
mairon-eero opened this issue Jul 15, 2024 · 3 comments

Comments

@mairon-eero
Copy link

Versions used

Akka version: Any version

Expected Behavior

Delay seconds parameter from SendMessageRequest should be forwarded to the batch requests

Actual Behavior

SendMessageBatchRequestEntry is build without the delay seconds parameter.
https://github.com/akka/alpakka/blob/main/sqs/src/main/scala/akka/stream/alpakka/sqs/scaladsl/SqsPublishFlow.scala#L85

            SendMessageBatchRequestEntry
              .builder()
              .id(i.toString)
              .messageBody(r.messageBody())
              .messageAttributes(r.messageAttributes())
              .messageGroupId(r.messageGroupId())
              .messageDeduplicationId(r.messageDeduplicationId())
              .build()
@ennru
Copy link
Member

ennru commented Jul 17, 2024

Thanks for reporting, feel free to suggest a pull request to set the attribute properly.

@mairon-eero
Copy link
Author

@ennru I believe the only thing needed to the code above is:

            SendMessageBatchRequestEntry
              .builder()
              .id(i.toString)
              .messageBody(r.messageBody())
              .messageAttributes(r.messageAttributes())
              .messageGroupId(r.messageGroupId())
              .messageDeduplicationId(r.messageDeduplicationId())
              // Add this new line
              .delaySeconds(r.delaySeconds())
              .build()

@ennru
Copy link
Member

ennru commented Aug 15, 2024

@ennru ennru closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants