Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Setup Classes to allow configuration without writing real HOCON #18

Closed
to11mtm opened this issue Feb 6, 2021 · 3 comments · Fixed by #456
Closed

Create Setup Classes to allow configuration without writing real HOCON #18

to11mtm opened this issue Feb 6, 2021 · 3 comments · Fixed by #456
Labels

Comments

@to11mtm
Copy link
Member

to11mtm commented Feb 6, 2021

With other parts of Akka.Net having ActorSystemSetup and similar, it would be nice to have the same capabilities here so that users can easily set up plugin configurations without having to write a bunch of HOCON.

This class should allow for configuration of all the 'important bits' that are exposed in HOCON configs.

  • It may be nice to provide a sort of 'forwarding' for providername with our own type/enum so users don't have to poke at Linq2Db.ProviderName
  • Validation/warning on invalid configs would also be a good idea (fail fast)
@Aaronontheweb
Copy link
Member

@to11mtm after some of the work we were doing on Akka.Persistence.Redis earlier this week, I was considering proposing this for Akka.Persistence in general - having a PersistenceSetup that can be subclassed and used to provide implementation-specific configuration.

The use case I really like this for - being able to pass in connection strings programmatically.

@Aaronontheweb
Copy link
Member

Akka.Peristence.Sql.Hosting solves this issue.

@Aaronontheweb
Copy link
Member

Eh, guess not - we need this for stuff like pass-through identity, akin to what we do for Akka.Persistence.SqlServer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants