From 502370edb508d984f1f1b4b05baae6cdfeb5e663 Mon Sep 17 00:00:00 2001 From: Ebere Abanonu Date: Thu, 4 May 2023 13:23:44 +0100 Subject: [PATCH] [CS0612] `QueryEventsSql` Warning Disable (#6702) * [CS0612] `QueryEventsSql` Warning Disable * Removed `QueryEventsSql` * fixed --- .../Journal/QueryExecutor.cs | 12 +----------- ...c.ApprovePersistenceSqlCommon.DotNet.verified.txt | 2 -- ...Spec.ApprovePersistenceSqlCommon.Net.verified.txt | 2 -- 3 files changed, 1 insertion(+), 15 deletions(-) diff --git a/src/contrib/persistence/Akka.Persistence.Sql.Common/Journal/QueryExecutor.cs b/src/contrib/persistence/Akka.Persistence.Sql.Common/Journal/QueryExecutor.cs index 32b0e2baea7..fa15e610dec 100644 --- a/src/contrib/persistence/Akka.Persistence.Sql.Common/Journal/QueryExecutor.cs +++ b/src/contrib/persistence/Akka.Persistence.Sql.Common/Journal/QueryExecutor.cs @@ -501,11 +501,6 @@ SELECT MAX(e.{Configuration.OrderingColumnName}) as Ordering @Tag, @SerializerId )"; - - QueryEventsSql = $@" - SELECT {allEventColumnNames} - FROM {Configuration.FullJournalTableName} e - WHERE "; } /// @@ -557,12 +552,7 @@ SELECT MAX(e.{Configuration.OrderingColumnName}) as Ordering /// protected abstract string CreateMetaTableSql { get; } - /// - /// TBD - /// - [Obsolete] - protected string QueryEventsSql { get; } - + /// /// TBD /// diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistenceSqlCommon.DotNet.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistenceSqlCommon.DotNet.verified.txt index f64a1896b16..93780b8f9d2 100644 --- a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistenceSqlCommon.DotNet.verified.txt +++ b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistenceSqlCommon.DotNet.verified.txt @@ -43,8 +43,6 @@ namespace Akka.Persistence.Sql.Common.Journal protected virtual string HighestSequenceNrSql { get; } protected virtual string HighestTagOrderingSql { get; } protected virtual string InsertEventSql { get; } - [System.ObsoleteAttribute()] - protected string QueryEventsSql { get; } public System.Data.IsolationLevel ReadIsolationLevel { get; } protected virtual string UpdateSequenceNrSql { get; } public System.Data.IsolationLevel WriteIsolationLevel { get; } diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistenceSqlCommon.Net.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistenceSqlCommon.Net.verified.txt index 5bed7aa6f96..6e8a604e37c 100644 --- a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistenceSqlCommon.Net.verified.txt +++ b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApprovePersistenceSqlCommon.Net.verified.txt @@ -43,8 +43,6 @@ namespace Akka.Persistence.Sql.Common.Journal protected virtual string HighestSequenceNrSql { get; } protected virtual string HighestTagOrderingSql { get; } protected virtual string InsertEventSql { get; } - [System.ObsoleteAttribute()] - protected string QueryEventsSql { get; } public System.Data.IsolationLevel ReadIsolationLevel { get; } protected virtual string UpdateSequenceNrSql { get; } public System.Data.IsolationLevel WriteIsolationLevel { get; }