From f2131991c6f620fe780158f4734329e554188e30 Mon Sep 17 00:00:00 2001 From: Milan Gardian Date: Wed, 8 Jan 2025 09:33:42 -0700 Subject: [PATCH] Remove support for serialization from "AkkaEqualException" --- .../Internals/AkkaEqualExceptionSpec.cs | 33 ------------------- .../Internals/AkkaEqualException.cs | 10 ------ ...c.ApproveTestKitXunit2.DotNet.verified.txt | 1 - ...Spec.ApproveTestKitXunit2.Net.verified.txt | 1 - 4 files changed, 45 deletions(-) delete mode 100644 src/contrib/testkits/Akka.TestKit.Xunit2.Tests/Internals/AkkaEqualExceptionSpec.cs diff --git a/src/contrib/testkits/Akka.TestKit.Xunit2.Tests/Internals/AkkaEqualExceptionSpec.cs b/src/contrib/testkits/Akka.TestKit.Xunit2.Tests/Internals/AkkaEqualExceptionSpec.cs deleted file mode 100644 index a9f1b4b54ea..00000000000 --- a/src/contrib/testkits/Akka.TestKit.Xunit2.Tests/Internals/AkkaEqualExceptionSpec.cs +++ /dev/null @@ -1,33 +0,0 @@ -// ----------------------------------------------------------------------- -// -// Copyright (C) 2009-2025 Lightbend Inc. -// Copyright (C) 2013-2025 .NET Foundation -// -// ----------------------------------------------------------------------- - -using Akka.TestKit.Xunit2.Internals; -using Xunit; - -namespace Akka.TestKit.Xunit2.Tests.Internals; - -public static class AkkaEqualExceptionSpec -{ -#if NETFRAMEWORK - [Fact] - public static void Constructor_deserializes_message() - { - var originalException = new AkkaEqualException("Test message"); - - AkkaEqualException deserializedException; - using (var memoryStream = new System.IO.MemoryStream()) - { - var formatter = new System.Runtime.Serialization.Formatters.Binary.BinaryFormatter(); - formatter.Serialize(memoryStream, originalException); - memoryStream.Seek(0, System.IO.SeekOrigin.Begin); - deserializedException = (AkkaEqualException)formatter.Deserialize(memoryStream); - } - - Assert.Equal(originalException.Message, deserializedException.Message); - } -#endif -} diff --git a/src/contrib/testkits/Akka.TestKit.Xunit2/Internals/AkkaEqualException.cs b/src/contrib/testkits/Akka.TestKit.Xunit2/Internals/AkkaEqualException.cs index 64a69a22929..6dddda6fc3b 100644 --- a/src/contrib/testkits/Akka.TestKit.Xunit2/Internals/AkkaEqualException.cs +++ b/src/contrib/testkits/Akka.TestKit.Xunit2/Internals/AkkaEqualException.cs @@ -6,7 +6,6 @@ //----------------------------------------------------------------------- using System; -using System.Runtime.Serialization; using Xunit.Sdk; #nullable enable @@ -15,7 +14,6 @@ namespace Akka.TestKit.Xunit2.Internals /// /// TBD /// - [Serializable] public class AkkaEqualException : XunitException { // Length of "Expected: " and "Actual: " @@ -53,14 +51,6 @@ public static AkkaEqualException ForMismatchedValues( public AkkaEqualException(string format = "", params object[] args) : base(BuildAssertionMessage(format, args)) { } - /// - /// Initializes a new instance of the class. - /// - /// The that holds the serialized object data about the exception being thrown. - /// The that contains contextual information about the source or destination. - protected AkkaEqualException(SerializationInfo info, StreamingContext context) - : base(info.GetString("Message")) { } - /// /// Builds assertion message by applying specified arguments to the format string. /// When no arguments are specified, format string is returned as-is. diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveTestKitXunit2.DotNet.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveTestKitXunit2.DotNet.verified.txt index df82f81663c..350493a40c3 100644 --- a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveTestKitXunit2.DotNet.verified.txt +++ b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveTestKitXunit2.DotNet.verified.txt @@ -37,7 +37,6 @@ namespace Akka.TestKit.Xunit2.Internals public class AkkaEqualException : Xunit.Sdk.XunitException { public AkkaEqualException(string format = "", params object[] args) { } - protected AkkaEqualException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { } [return: System.Runtime.CompilerServices.NullableAttribute(1)] public static Akka.TestKit.Xunit2.Internals.AkkaEqualException ForMismatchedValues(object expected, object actual, string format = null, [System.Runtime.CompilerServices.NullableAttribute(1)] params object[] args) { } } diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveTestKitXunit2.Net.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveTestKitXunit2.Net.verified.txt index 881e30f215f..11d9307f3a1 100644 --- a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveTestKitXunit2.Net.verified.txt +++ b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveTestKitXunit2.Net.verified.txt @@ -37,7 +37,6 @@ namespace Akka.TestKit.Xunit2.Internals public class AkkaEqualException : Xunit.Sdk.XunitException { public AkkaEqualException(string format = "", params object[] args) { } - protected AkkaEqualException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { } [return: System.Runtime.CompilerServices.NullableAttribute(1)] public static Akka.TestKit.Xunit2.Internals.AkkaEqualException ForMismatchedValues(object expected, object actual, string format = null, [System.Runtime.CompilerServices.NullableAttribute(1)] params object[] args) { } }