-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change immutable map implementation #1175
Comments
We should give this a try imo. the AVL tree is horribly slow when inserting a lot of children. |
Related? #1202 |
Hi, I have been playing with the Red-Black tree implementation for the last few days. It's not complete yet, but you can check out the current code here: https://github.com/kbaldyga/Tree Before (if) I start working on a pull-request integrating this with akka.net, I have few questions:
|
It'd need to be in C# so we can integrate it into the core library (C#) |
The AVL null ref exception is fixed in PR #1645 . Other reasons obviously stand. |
Resolved as part of #1676 |
Right now our
IImmutableMap<TKey, TValue>
implementation is based on AVL trees. It's used i.e. in child actors containers. However it has some known perf issues when it comes to adding new child actors. Also current impl doesn't support range queries, which will be highly desirable i.e. inAkka.Cluster.Tools
plugin.The idea is to switch implementation to Red-Black trees (like the ones used in Scala implementation). Any other ideas? @akkadotnet/developers
The text was updated successfully, but these errors were encountered: