Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka.Remote: cache client and server bootstrappers for DotNetty #3434

Closed
Aaronontheweb opened this issue May 4, 2018 · 2 comments
Closed

Comments

@Aaronontheweb
Copy link
Member

Version: Akka.NET v1.3.6

While looking into #3430, it's been suggested to me that we cache the bootstrappers for both the client and the server since they're designed to be re-usable configuration objects. It's a relatively minor change that may not any real performance impact, but every bit can help.

@Aaronontheweb
Copy link
Member Author

Looks like the ServerBootstrapper is already cached, since we only create it once at startup.

@Aaronontheweb
Copy link
Member Author

Also, looks like we can't cache the ClientBootstrap since it passes in unique data we need on a per-connection basis, namely the address of the remote endpoint. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant