Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

akka.net and system.runtime both contain system.serializeattribute #3523

Closed
ignite-404 opened this issue Jun 23, 2018 · 11 comments
Closed

akka.net and system.runtime both contain system.serializeattribute #3523

ignite-404 opened this issue Jun 23, 2018 · 11 comments
Assignees
Milestone

Comments

@ignite-404
Copy link

akka.net and system.runtime both contain system.serializeattribute

version:
.net core 2.0
akka 1.3.8

here is the screen shot:
http://hiwjcn.qiniudn.com/TIM%E6%88%AA%E5%9B%BE20180623190332.png
if can't see the pic,direct to http://hiwjcn.qiniudn.com/TIM%E6%88%AA%E5%9B%BE20180623190332.png

@Aaronontheweb
Copy link
Member

@hiwjcn yes, these are polyfills from the pre-.NET Standard 2.0 days. In order to target .NET Standard 1.6 we had to add them back since the SerializableAttribute wasn't part of the .NET Standard library.

They reversed that decision in .NET Standard 2.0.

We're in the process of moving Akka.NET onto .NET Standard 2.0 as part of our v1.4.0 release and we'll go through and remove these once that's finished. #3452

In the meantime, this is stopping you from writing unit tests that utilize the Serializable attribute?

@Aaronontheweb Aaronontheweb added this to the 1.4.0 milestone Jun 24, 2018
@Aaronontheweb
Copy link
Member

cc @Danthar you're still working on this, right?

@ignite-404
Copy link
Author

@Aaronontheweb thanks for ur patient help

@Danthar
Copy link
Member

Danthar commented Jun 25, 2018

@Aaronontheweb Yup

@dgioulakis
Copy link

Is there any temporary solution to this? Shall I just use DataContract and place DataMember on all fields?

@Aaronontheweb
Copy link
Member

Other than recompiling Akka.NET in your own fork without those polyfills, no - or don't use the Serializable attribute like you suggested. There are some other work-arounds suggested here: #3161

We'll have this fixed in the v1.4 release but there's nothing we can do between now and then given that this requires a platform change (i.e. we have to move onto .NET Standard 2.0 to not need the polyfills anymore.)

@dgioulakis
Copy link

Much appreciated @Aaronontheweb. Looking forward to 1.4 / Standard 2.0!

@ignite-404
Copy link
Author

@Aaronontheweb haha can't wait for the version 1.4,can i have the release scheduler?

@saxenashubham
Copy link

@Aaronontheweb when can we expect the release of v1.4?

@crasshacker
Copy link

Has anyone managed to modify the Akka.NET sources to remove the SerializableAttribute polyfill and compile Akka.NET (core and remote libraries) for netstandard 2.0? Also, is there an update on when Akka 1.4 will be released, with netstandard 2.0 officially supported?

@Aaronontheweb
Copy link
Member

Resolved. Pushing first beta of Akka.NET v1.4 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants