Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate all protobuf messages (#6082) #6087

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

Arkatufus
Copy link
Contributor

A sort of "backport" of #6082
Regenerate the protobuf codes in 1.4 branch

Benchmark Result

Before

BenchmarkDotNet=v0.13.1, OS=Windows 10.0.19041.1415 (2004/May2020Update/20H1)
AMD Ryzen 9 3900X, 1 CPU, 24 logical and 12 physical cores
.NET SDK=6.0.200
  [Host]     : .NET 6.0.2 (6.0.222.6406), X64 RyuJIT
  DefaultJob : .NET 6.0.2 (6.0.222.6406), X64 RyuJIT
Method Mean Error StdDev Gen 0 Gen 1 Allocated
WritePayloadPdu 1,669.6 ns 21.10 ns 19.74 ns 0.2156 - 1,808 B
DecodePayloadPdu 2,039.7 ns 12.52 ns 11.71 ns 0.2156 0.0031 1,816 B
DecodePduOnly 131.3 ns 1.32 ns 1.11 ns 0.0563 0.0002 472 B
DecodeMessageOnly 1,665.0 ns 15.03 ns 14.05 ns 0.1406 - 1,184 B
DeserializePayloadOnly 151.2 ns 1.88 ns 1.76 ns 0.0199 - 168 B

After

BenchmarkDotNet=v0.13.1, OS=Windows 10.0.19041.1415 (2004/May2020Update/20H1)
AMD Ryzen 9 3900X, 1 CPU, 24 logical and 12 physical cores
.NET SDK=6.0.200
  [Host]     : .NET 6.0.2 (6.0.222.6406), X64 RyuJIT
  DefaultJob : .NET 6.0.2 (6.0.222.6406), X64 RyuJIT
Method Mean Error StdDev Gen 0 Gen 1 Allocated
WritePayloadPdu 1,623.4 ns 19.95 ns 18.66 ns 0.2219 0.0031 1,880 B
DecodePayloadPdu 1,738.6 ns 22.79 ns 21.31 ns 0.2250 - 1,888 B
DecodePduOnly 175.1 ns 2.31 ns 1.93 ns 0.0572 - 480 B
DecodeMessageOnly 1,296.8 ns 11.89 ns 10.54 ns 0.1469 0.0016 1,232 B
DeserializePayloadOnly 143.6 ns 1.59 ns 1.33 ns 0.0199 0.0002 168 B

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) August 31, 2022 16:42
@Aaronontheweb Aaronontheweb added this to the 1.4.41 milestone Aug 31, 2022
@Aaronontheweb
Copy link
Member

LGTM

@Aaronontheweb Aaronontheweb disabled auto-merge August 31, 2022 17:30
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) August 31, 2022 17:30
@Aaronontheweb Aaronontheweb merged commit 1a1c4b6 into akkadotnet:v1.4 Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants