Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook fails to run properly with cordova 6.3.1 #14

Closed
betko opened this issue Sep 8, 2016 · 3 comments
Closed

Hook fails to run properly with cordova 6.3.1 #14

betko opened this issue Sep 8, 2016 · 3 comments

Comments

@betko
Copy link

betko commented Sep 8, 2016

I'm facing an issue with the plugin when running with: cordova@6.3.1. The cordova hook which sets the Bridging Headers and the xcode project properties, is not executed after cordova prepare.

The plugins works properly with cordova@6.1.1.

Modifying the hook condition seems to fix the issue:

if ((context.hook === 'after_platform_add' && context.cmdLine.includes('platform add')) ||
    (context.hook === 'after_prepare' && context.cmdLine.includes('prepare')) ||
    (context.hook === 'after_plugin_add' && context.cmdLine.includes('prepare')) ||
    (context.hook === 'after_plugin_add' && context.cmdLine.includes('plugin add'))) {
// ...
}

If the fix looks okey, I can make a PR. 😸

@akofman
Copy link
Owner

akofman commented Sep 9, 2016

Hello @betko, thanks for your help. I'll look at that this weekend and keep you in touch.

@akofman
Copy link
Owner

akofman commented Oct 14, 2016

Hello @betko ! Sorry for the laaaaaaaate. You're right and your fix looks fine, PR is welcome.

@akofman
Copy link
Owner

akofman commented Jan 9, 2017

I can't reproduce it anymore so I close this issue.
I tried to reproduce with the cordova-plugin-permissionScope and cordova@6.3.1.
I removed the #import "PermissionScope-Bridging-Header.h" from the Bridging-Header.h then run cordova prepare, I can see it well configured again as expected.

@akofman akofman closed this as completed Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants