Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement catching promise rejections #51

Closed
ghost opened this issue Mar 16, 2018 · 2 comments
Closed

Implement catching promise rejections #51

ghost opened this issue Mar 16, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Mar 16, 2018

Hi,

promise rejections of functions like getPlatformVersionsFromFileSystem are not caught, thus if something fails other cordova plugins are not added to the Bridging-Header.h and builds may fail.

getPlatformVersionsFromFileSystem failed for me due to a folder in the projectRoot containing a special character, but since the rejection was not caught this was very difficult to figure out.

Otherwise great plugin!

Regards

@TheLiquidSky
Copy link

This is relevant to my PR #52.

@akofman
Copy link
Owner

akofman commented Mar 30, 2018

Fixed in PR #52

@akofman akofman closed this as completed Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants