Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows assets are not applied #9

Open
leonskim opened this issue Dec 29, 2016 · 4 comments
Open

Windows assets are not applied #9

leonskim opened this issue Dec 29, 2016 · 4 comments

Comments

@leonskim
Copy link

I've added react-native-router-flux into my project and react-native-experimental-navigation has been added as a dependency too. Although the Windows assets were committed already(c862d77), I'm not seeing those in node_modules/react-native-experimental-navigation/assets

$ npm i
MY_PRJ
`-- react-native-router-flux@3.37.0
  `-- react-native-experimental-navigation@0.26.10

There are only iOS and Android assets.

$ ls
'back@1.5x.android.png'  'back@1x.ios.png'      'back@3x.android.png'  'back@4x.ios.png'
'back@1.5x.ios.png'      'back@2x.android.png'  'back@3x.ios.png'
'back@1x.android.png'    'back@2x.ios.png'      'back@4x.android.png'

Can anyone confirm this?

@jmarrot
Copy link

jmarrot commented Jan 13, 2017

Me too 👍

@aksonov an idea ?

@aksonov
Copy link
Owner

aksonov commented Jan 16, 2017 via email

@jmarrot
Copy link

jmarrot commented Jan 16, 2017

It's just a problem of published version.

If i write in package.json :
"react-native-experimental-navigation": "https://github.com/aksonov/react-native-experimental-navigation#c862d77", it's ok.

In this package : https://registry.npmjs.org/react-native-experimental-navigation/-/react-native-experimental-navigation-0.26.10.tgz theys files (for Windows) are not found.

@leesolway
Copy link

Having the same issue.. A new release to deploy these Windows assets would be great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants