Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update image in local helm chart #1188

Closed
rbreeze opened this issue Nov 30, 2023 · 2 comments
Closed

chore: Update image in local helm chart #1188

rbreeze opened this issue Nov 30, 2023 · 2 comments

Comments

@rbreeze
Copy link
Contributor

rbreeze commented Nov 30, 2023

When running helm install kargo ./charts/kargo, the installation still uses the v0.1.0 image. This causes errors when applying Kargo resources as much has changed since 0.1.0

@krancour
Copy link
Member

Ah...

So v0.1.0 was just a placeholder. (It didn't let me do v.0.0.0. I tried!) The release process inserts the correct version number.

But if you use helm install kargo ./charts/kargo, you're getting stuck with that placeholder. ☹️

I don't typically encounter this because I'm using Tilt and it automatically builds images, pushes them to a local registry, and updates the rendered YAML from helm template ./charts/kargo, setting the image version correctly, by digest.

I suppose the bug here may not actually be a matter of changing that placeholder, but more a matter of having a convenient way (besides Tilt?) of "shimming" a locally built, un-official image into the chart for development purposes.

@krancour
Copy link
Member

krancour commented Apr 2, 2024

I think we agreed that the release process sets this value properly and during development Tilt seamlessly handles shimming a locally built image into the chart. When Tilt was slower, I could see an alternative method of accomplishing that shimming as being needed, but #1248 resolved slowness issues. I don't think we can build a more seamless way of doing what Tilt is doing for us, so I am tentatively closing this.

@krancour krancour closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants