Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --wait to promotion command #1888

Closed
3 tasks done
christianh814 opened this issue Apr 22, 2024 · 1 comment · Fixed by #1890
Closed
3 tasks done

Add --wait to promotion command #1888

christianh814 opened this issue Apr 22, 2024 · 1 comment · Fixed by #1890

Comments

@christianh814
Copy link
Member

christianh814 commented Apr 22, 2024

Checklist

  • I've searched the issue queue to verify this is not a duplicate feature request.
  • I've pasted the output of kargo version, if applicable.
  • I've pasted logs, if applicable.

Proposed Feature

Add a --wait option to kargo promote so the CLI won't return until the promotion succeeds or fails

Example:

kargo promote --project kargo-demo --freight-alias frisky-wookie --stage test --wait

Motivation

Some users may opt to script (or use kargo cli in a CI process) and need the promote operation to be a blocking operation.

Suggested Implementation

No suggestions but something to keep in mind is other places where a wait should be implemented. There should also be a timeout condition like in kubectl so it won't wait indefinitely (like --timeout=300s)

@hiddeco hiddeco changed the title Add --wait to promotio command Add --wait to promotion command Apr 22, 2024
@hiddeco
Copy link
Contributor

hiddeco commented Apr 22, 2024

This has likely become more important since #1613, as Promotions can be long(er) running now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants