Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: edges should come in/out to Promote buttons #712

Closed
jessesuen opened this issue Sep 12, 2023 · 1 comment · Fixed by #745 or #747
Closed

UI: edges should come in/out to Promote buttons #712

jessesuen opened this issue Sep 12, 2023 · 1 comment · Fixed by #745 or #747

Comments

@jessesuen
Copy link
Member

jessesuen commented Sep 12, 2023

In the following DAG, the edges coming out of the node come from the top and bottom of the upstream node. Because of that, they are disconnected from the PromoteSubscribers button.

image

Since the intent of the PromoteSubscribers button is to promote to downstream, I feel the edges should originate out of the button as a better visual indicator of what will be affected..

It seems possible because Argo CD can do it (and we use the same DAG library):

image

Also, maybe we should use this chance to make the promote subscribers more obviously a button. I think it may not be clear.

@jessesuen
Copy link
Member Author

jessesuen commented Sep 13, 2023

For some reason, the left side didn't get the same treatment as the right, so reopening

EDIT: probably that reason is because I only asked for PromoteSubscribers in the title and not Promote 🤦‍♂️ . But I actually meant both. Sorry for not being clear!

image image

@jessesuen jessesuen reopened this Sep 13, 2023
@jessesuen jessesuen changed the title UI: edges should come out from PromoteSubscribers button UI: edges should come in/out to Promote buttons Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment