Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The video in the README looks like an image #754

Closed
alexec opened this issue Sep 13, 2023 · 5 comments · Fixed by #765
Closed

The video in the README looks like an image #754

alexec opened this issue Sep 13, 2023 · 5 comments · Fixed by #765

Comments

@alexec
Copy link

alexec commented Sep 13, 2023

I wanted to watch a video. You have a video. It's in the readme. It is not discoverable.

Better if the image had the video play icon on it. It looks like this was done correctly in the Markdown, but is not showing right.

https://stackoverflow.com/questions/11804820/how-can-i-embed-a-youtube-video-on-github-wiki-pages

@krancour
Copy link
Member

@alexec I actually spent more time than I care to admit trying to properly embed the video in the README and even consulted the exact Stack Overflow page you linked to. What we did is the same as their accepted answer.

I still wish this were better, but I'm at a loss for how to do it.

Do you have an example of a README elsewhere on GitHub that has done this successfully?

@krancour
Copy link
Member

krancour commented Sep 14, 2023

Also, just fyi, the video is very stale at this point -- which is its own problem. Documentation text is up to date, however (but continuously improving).

@alexec
Copy link
Author

alexec commented Sep 14, 2023

Yah. Not sure why the recommended way does not have the usual "play" icon.

@krancour
Copy link
Member

@morey-tech since you've been ramping up on doc improvements, I will tentatively assign this to you, but I'm not sure there's much that can be done here.

@krancour
Copy link
Member

This video has actually be removed since it is so stale. We'll try to do a better job when we replace it shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants