Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendered Manifests branches should be a reflection of the Trunk #888

Closed
christianh814 opened this issue Sep 29, 2023 · 2 comments
Closed

Comments

@christianh814
Copy link
Member

christianh814 commented Sep 29, 2023

When Kargo is set up to use the rendered manifest pattern, the branch it creates should be a reflection of the trunk. Example, Kargo would do the equivalent of:

  1. Run kustomize set image in the given path on main (or specified trunk)
  2. Commit that to main
  3. Render the manifests to env/dev (or specified branch)

It's understood that this causes a "subscription loop", but after talking to @jessesuen - there might be a few ways to solve that so I'm opening this issue for posterity.

@krancour
Copy link
Member

I will put some thought into this, but I think this creates other problems besides the subscription loop.

@krancour
Copy link
Member

It seems this isn't proving to be as much of a sticking point for people as we may have feared it might be.

If it is, there's an sensible and easy pattern-based approach to solving for it: See #1119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants