Adding tests that show errors in deserialization #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - test for invalid custom serialization - test for invalid inline serialization
…x/invalid-traversal � Conflicts: � ktoml-core/src/commonTest/kotlin/com/akuleshov7/ktoml/decoders/InlineDecoderTest.kt
orchestr7
force-pushed
the
bugfix/invalid-traversal
branch
from
85bb617 to
0d1b848
Compare
orchestr7
commented
Apr 28, 2022
| data class Settings(val background: SingleProperty, val foreground: SingleProperty) | ||
|
|
||
| @Test | ||
| @Ignore |
There was a problem hiding this comment.
This test does not work, but I actually would have expected it be working
| class Color(val rgb: Int) | ||
|
|
||
| @Test | ||
| @Ignore |
There was a problem hiding this comment.
This is the example from https://github.com/Kotlin/kotlinx.serialization/blob/master/docs/serializers.md#composite-serializer-via-surrogate
Also not working
…ov7/ktoml into bugfix/invalid-traversal � Conflicts: � ktoml-core/src/commonMain/kotlin/com/akuleshov7/ktoml/decoders/TomlMainDecoder.kt
|
@bishiboosh @NightEule5 this is a very small PR with a workaround for custom serializers (with the override of I hope you don't mind if I merge it without the review as it is very primitive - just a small hack. I also have found that some more complex cases are not working, so I have added tests and ignored them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: