From d67cf474ceb5932b996438953536a87a355a6077 Mon Sep 17 00:00:00 2001 From: "darkhan.nausharipov" Date: Mon, 6 Feb 2023 22:51:55 +0600 Subject: [PATCH] pre-review fixes (#25255) --- .../frontend/lib/components/profile/user_menu.dart | 2 +- .../frontend/lib/pages/tour/widgets/hints.dart | 1 - .../frontend/lib/pages/tour/widgets/solution_button.dart | 7 ++----- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/learning/tour-of-beam/frontend/lib/components/profile/user_menu.dart b/learning/tour-of-beam/frontend/lib/components/profile/user_menu.dart index 94dc350adc7f6..2f0cc83aed8dc 100644 --- a/learning/tour-of-beam/frontend/lib/components/profile/user_menu.dart +++ b/learning/tour-of-beam/frontend/lib/components/profile/user_menu.dart @@ -132,9 +132,9 @@ class _Buttons extends StatelessWidget { builder: (context) => Dialog( backgroundColor: Colors.transparent, child: BeamAlertDialog( + body: 'dialogs.deleteAccountWarning'.tr(), continueLabel: 'ui.deleteMyAccount'.tr(), title: 'ui.deleteTobAccount'.tr(), - body: 'dialogs.deleteAccountWarning'.tr(), onContinue: () { authNotifier.deleteAccount().then( (_) { diff --git a/learning/tour-of-beam/frontend/lib/pages/tour/widgets/hints.dart b/learning/tour-of-beam/frontend/lib/pages/tour/widgets/hints.dart index dc045f447f3b2..57d9cfacf73d6 100644 --- a/learning/tour-of-beam/frontend/lib/pages/tour/widgets/hints.dart +++ b/learning/tour-of-beam/frontend/lib/pages/tour/widgets/hints.dart @@ -22,7 +22,6 @@ import 'package:flutter_svg/svg.dart'; import 'package:playground_components/playground_components.dart'; import '../../../assets/assets.gen.dart'; -import '../../../constants/sizes.dart'; import 'markdown/tob_markdown.dart'; class HintsWidget extends StatelessWidget { diff --git a/learning/tour-of-beam/frontend/lib/pages/tour/widgets/solution_button.dart b/learning/tour-of-beam/frontend/lib/pages/tour/widgets/solution_button.dart index ead733280d25e..96a05b1b7ea1e 100644 --- a/learning/tour-of-beam/frontend/lib/pages/tour/widgets/solution_button.dart +++ b/learning/tour-of-beam/frontend/lib/pages/tour/widgets/solution_button.dart @@ -44,6 +44,7 @@ class SolutionButton extends StatelessWidget { ), ), onPressed: () { + // TODO(nausharipov): resolve the conflict with save user code showDialog( context: context, builder: (context) => Dialog( @@ -60,11 +61,7 @@ class SolutionButton extends StatelessWidget { ); }, icon: SvgPicture.asset(Assets.svg.solution), - label: Text( - tourNotifier.isShowingSolution - ? 'pages.tour.assignment' - : 'pages.tour.solution', - ).tr(), + label: const Text('ui.solution').tr(), ), ); }