fix(popover): get back default 15px offset (#1201)

akveo · Jan 31, 2019 · f7433e7 · f7433e7
1 parent 7e38c02
commit f7433e7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/framework/theme/components/cdk/overlay/dynamic/dynamic-overlay-handler.spec.ts b/src/framework/theme/components/cdk/overlay/dynamic/dynamic-overlay-handler.spec.ts
@@ -406,7 +406,7 @@ describe('dynamic-overlay-handler', () => {
     expect(positionBuilder._connectedTo).toBe(host1);
     expect(positionBuilder._position).toBe(NbPosition.TOP);
     expect(positionBuilder._adjustment).toBe(NbAdjustment.NOOP);
-    expect(positionBuilder._offset).toBe(0);
+    expect(positionBuilder._offset).toBe(15);
 
     configure().host(host2).rebuild();
     expect(triggerStrategyBuilder._host).toBe(host2.nativeElement);
@@ -415,7 +415,7 @@ describe('dynamic-overlay-handler', () => {
     expect(positionBuilder._connectedTo).toBe(host2);
     expect(positionBuilder._position).toBe(NbPosition.TOP);
     expect(positionBuilder._adjustment).toBe(NbAdjustment.NOOP);
-    expect(positionBuilder._offset).toBe(0);
+    expect(positionBuilder._offset).toBe(15);
   });
 
   it('should set and update position', () => {

diff --git a/src/framework/theme/components/cdk/overlay/dynamic/dynamic-overlay-handler.ts b/src/framework/theme/components/cdk/overlay/dynamic/dynamic-overlay-handler.ts
@@ -34,7 +34,7 @@ export class NbDynamicOverlayHandler {
   protected _trigger: NbTrigger = NbTrigger.NOOP;
   protected _position: NbPosition = NbPosition.TOP;
   protected _adjustment: NbAdjustment = NbAdjustment.NOOP;
-  protected _offset: number = 0;
+  protected _offset: number = 15;
 
   protected dynamicOverlay: NbDynamicOverlay;
 

diff --git a/src/framework/theme/components/popover/popover.directive.ts b/src/framework/theme/components/popover/popover.directive.ts
@@ -78,7 +78,7 @@ import { NbPopoverComponent } from './popover.component';
  * If you wanna disable this behaviour just set it falsy value.
  *
  * ```html
- * <button nbPopover="Hello, Popover!" [nbPopoverAdjust]="false"></button>
+ * <button nbPopover="Hello, Popover!" [nbPopoverAdjustment]="false"></button>
  * ```
  *
  * Popover has a number of triggers which provides an ability to show and hide the component in different ways: