feat(badge): add new badge component #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yggg let's check why the tests are failing and please rebase on master so that we can merge it. |
nnixaa
requested changes
Dec 21, 2017
| @@ -24,6 +24,7 @@ import { convertToBoolProperty } from '../helpers'; | |||
| <ng-template #showContent> | |||
| <ng-content></ng-content> | |||
| </ng-template> | |||
| <nb-badge *ngIf="badgeText" text={{badgeText}} status={{badgeStatus}} position={{badgePosition}}></nb-badge> | |||
There was a problem hiding this comment.
Let's add spaces inside of {{ }} statement. Moreover, in this case [text]="badgeText" [status]="badgeStatus" should look even better.
| @@ -103,6 +124,11 @@ export class NbTabComponent { | |||
| (click)="selectTab(tab)" | |||
| [class.active]="tab.active"> | |||
| <a href (click)="$event.preventDefault()">{{ tab.tabTitle }}</a> | |||
| <nb-badge *ngIf="tab.badgeText" | |||
| @@ -115,6 +115,13 @@ $theme: ( | |||
| smart-table-paging-fg-active: color-fg-heading, | |||
| smart-table-paging-bg-active: color-primary, | |||
| smart-table-paging-hover: rgba(0, 0, 0, 0.2), | |||
|
|
|||
| badge-fg-text: color-fg-text, | |||
| @@ -398,6 +398,13 @@ $theme: ( | |||
| modal-body-font-weight: font-weight-normal, | |||
| modal-body-font-size: font-size, | |||
| modal-separator: separator, | |||
|
|
|||
| badge-fg-text: color-fg-text, | |||
nnixaa
previously approved these changes
Dec 29, 2017
|
@yggg we probably have to make the component public at the end, as currently we won't have any documentation on it and it won't be clear how to change its styles. Let's discuss next week. |
nnixaa
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.