Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): Eva style #1391

Merged
merged 62 commits into from
Apr 24, 2019
Merged

feat(select): Eva style #1391

merged 62 commits into from
Apr 24, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 17, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGE:

Arrow selector and element changed to svg icon.

NbSelectComponent 'isOpened' getter renamed to 'isOpen'.

NbOptionComponent and NbOptionGroupComponent 'disabledClass' getter
renamed to 'disabledAttribute'.

Following theme properties were renamed:
select-border-width -> select-[appearance]-border-width
select-max-height -> select-options-list-max-height
select-bg -> select-[appearance]-background-color
select-option-disabled-bg -> select-option-[appearance]-disabled-background-color
select-option-padding -> select-option-[appearance]-[size]-padding

Following theme properties removed:
select-checkmark-color
select-checkbox-color
select-option-disabled-opacity

yggg added 28 commits April 17, 2019 21:07
BREAKING CHANGE:

Arrow selector and element changed to svg icon.
BREAKING CHANGE:

NbSelectComponent 'isOpened' getter renamed to 'isOpen'
BREAKING CHANGE:

NbOptionComponent and NbOptionGroupComponent 'disabledClass' getter
renamed to 'disabledAttribute'
BREAKING CHANGE:
Following theme properties were renamed:
select-border-width -> select-[appearance]-border-width
select-max-height -> select-options-list-max-height
select-bg -> select-[appearance]-background-color
select-option-disabled-bg -> select-option-[appearance]-disabled-background-color
select-option-padding -> select-option-[appearance]-[size]-padding

Following theme properties removed:
select-checkmark-color
select-checkbox-color
select-option-disabled-opacity
@yggg yggg requested a review from nnixaa April 17, 2019 18:22
@nnixaa
Copy link
Collaborator

nnixaa commented Apr 22, 2019

image
seems like the smaller one isn't really smaller?

@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #1391 into next will decrease coverage by 0.07%.
The diff coverage is 85.05%.

@@            Coverage Diff            @@
##            next    #1391      +/-   ##
=========================================
- Coverage   82.7%   82.63%   -0.08%     
=========================================
  Files        238      238              
  Lines       7229     7285      +56     
  Branches     635      642       +7     
=========================================
+ Hits        5979     6020      +41     
- Misses      1065     1076      +11     
- Partials     185      189       +4
Impacted Files Coverage Δ
...framework/theme/components/select/select.module.ts 100% <100%> (ø) ⬆️
.../theme/components/select/option-group.component.ts 81.81% <66.66%> (-8.19%) ⬇️
...mework/theme/components/select/option.component.ts 95.34% <75%> (-2.28%) ⬇️
...mework/theme/components/select/select.component.ts 89.4% <87.5%> (-1.86%) ⬇️
...mework/theme/components/button/button.component.ts 87.2% <0%> (-4.66%) ⬇️

@@ -108,7 +108,7 @@
}
}

@include select-outline;
@include select-outline();
@include select-filled;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, how about the others?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed f20a192

@nnixaa
Copy link
Collaborator

nnixaa commented Apr 22, 2019

And can we also fix the circular dependency warning as part of it?

@yggg
Copy link
Contributor Author

yggg commented Apr 24, 2019

And can we also fix the circular dependency warning as part of it?

Will fix in the keyboard pr

@yggg yggg closed this Apr 24, 2019
@yggg yggg reopened this Apr 24, 2019
nnixaa
nnixaa previously approved these changes Apr 24, 2019
@yggg yggg merged commit e31c083 into akveo:next Apr 24, 2019
yggg added a commit that referenced this pull request May 27, 2019
BREAKING CHANGE:

Arrow selector and element changed to svg icon.

NbSelectComponent 'isOpened' getter renamed to 'isOpen'.

NbOptionComponent and NbOptionGroupComponent 'disabledClass' getter
renamed to 'disabledAttribute'.

Following theme properties were renamed:
select-border-width -> select-[appearance]-border-width
select-max-height -> select-options-list-max-height
select-bg -> select-[appearance]-background-color
select-option-disabled-bg -> select-option-[appearance]-disabled-background-color
select-option-padding -> select-option-[appearance]-[size]-padding

Following theme properties removed:
select-checkmark-color
select-checkbox-color
select-option-disabled-opacity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants