-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): Eva style #1391
feat(select): Eva style #1391
Conversation
BREAKING CHANGE: Arrow selector and element changed to svg icon.
BREAKING CHANGE: NbSelectComponent 'isOpened' getter renamed to 'isOpen'
BREAKING CHANGE: NbOptionComponent and NbOptionGroupComponent 'disabledClass' getter renamed to 'disabledAttribute'
BREAKING CHANGE: Following theme properties were renamed: select-border-width -> select-[appearance]-border-width select-max-height -> select-options-list-max-height select-bg -> select-[appearance]-background-color select-option-disabled-bg -> select-option-[appearance]-disabled-background-color select-option-padding -> select-option-[appearance]-[size]-padding Following theme properties removed: select-checkmark-color select-checkbox-color select-option-disabled-opacity
src/framework/theme/components/select/_select.component.theme.scss
Outdated
Show resolved
Hide resolved
Co-Authored-By: yggg <yggg@users.noreply.github.com>
Since outline is was already presented in all examples before.
Codecov Report
@@ Coverage Diff @@
## next #1391 +/- ##
=========================================
- Coverage 82.7% 82.63% -0.08%
=========================================
Files 238 238
Lines 7229 7285 +56
Branches 635 642 +7
=========================================
+ Hits 5979 6020 +41
- Misses 1065 1076 +11
- Partials 185 189 +4
|
@@ -108,7 +108,7 @@ | |||
} | |||
} | |||
|
|||
@include select-outline; | |||
@include select-outline(); | |||
@include select-filled; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, how about the others?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed f20a192
And can we also fix the circular dependency warning as part of it? |
Will fix in the keyboard pr |
BREAKING CHANGE: Arrow selector and element changed to svg icon. NbSelectComponent 'isOpened' getter renamed to 'isOpen'. NbOptionComponent and NbOptionGroupComponent 'disabledClass' getter renamed to 'disabledAttribute'. Following theme properties were renamed: select-border-width -> select-[appearance]-border-width select-max-height -> select-options-list-max-height select-bg -> select-[appearance]-background-color select-option-disabled-bg -> select-option-[appearance]-disabled-background-color select-option-padding -> select-option-[appearance]-[size]-padding Following theme properties removed: select-checkmark-color select-checkbox-color select-option-disabled-opacity
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
BREAKING CHANGE:
Arrow selector and element changed to svg icon.
NbSelectComponent 'isOpened' getter renamed to 'isOpen'.
NbOptionComponent and NbOptionGroupComponent 'disabledClass' getter
renamed to 'disabledAttribute'.
Following theme properties were renamed:
select-border-width -> select-[appearance]-border-width
select-max-height -> select-options-list-max-height
select-bg -> select-[appearance]-background-color
select-option-disabled-bg -> select-option-[appearance]-disabled-background-color
select-option-padding -> select-option-[appearance]-[size]-padding
Following theme properties removed:
select-checkmark-color
select-checkbox-color
select-option-disabled-opacity