Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): add missing start and end positions to positions mapping #1904

Merged
merged 3 commits into from
Aug 20, 2019
Merged

fix(popover): add missing start and end positions to positions mapping #1904

merged 3 commits into from
Aug 20, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Aug 13, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1147

@yggg yggg requested a review from nnixaa August 13, 2019 15:24
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #1904 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1904      +/-   ##
==========================================
+ Coverage   83.97%   83.98%   +0.01%     
==========================================
  Files         234      234              
  Lines        7674     7675       +1     
  Branches      672      672              
==========================================
+ Hits         6444     6446       +2     
+ Misses       1032     1031       -1     
  Partials      198      198
Impacted Files Coverage Δ
...k/theme/components/cdk/overlay/overlay-position.ts 90.42% <100%> (+1.17%) ⬆️

@yggg yggg marked this pull request as ready for review August 14, 2019 09:05
nnixaa
nnixaa previously approved these changes Aug 14, 2019
@nnixaa
Copy link
Collaborator

nnixaa commented Aug 14, 2019

@yggg, I believe we need a test here, don't we?

@yggg yggg merged commit 64777a4 into akveo:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbPopoverDirective doesn't work when position=start/end and adjustment=noop
2 participants