Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): use cli version for schematics/angular package #1937

Merged
merged 3 commits into from
Aug 29, 2019

Conversation

djhojd
Copy link
Contributor

@djhojd djhojd commented Aug 28, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Using angular/core package version for schematics/angular it will sometimes raise "No matching version found" error because they are in sync only with the major versions. The schematics scoped packages are under the Angular CLI repo and they will be released together. By using the CLI version when add the schematics/angular package to the devDependencies we will, hopefully, be sure that the version exists and is published to npm.

Closes #1864

@djhojd djhojd mentioned this pull request Aug 28, 2019
2 tasks
Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @djhojd 👍

@yggg yggg merged commit 4589726 into akveo:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add @nebular/theme Error
2 participants