Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): prevent transition to initial status #2256

Merged
merged 5 commits into from
Mar 6, 2020
Merged

fix(theme): prevent transition to initial status #2256

merged 5 commits into from
Mar 6, 2020

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Mar 6, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2207

@yggg yggg added this to the 5.0.0 milestone Mar 6, 2020
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #2256 into master will decrease coverage by 0.04%.
The diff coverage is 84.44%.

@@            Coverage Diff             @@
##           master    #2256      +/-   ##
==========================================
- Coverage   81.66%   81.61%   -0.05%     
==========================================
  Files         244      244              
  Lines        7329     7359      +30     
  Branches      771      771              
==========================================
+ Hits         5985     6006      +21     
- Misses       1116     1126      +10     
+ Partials      228      227       -1
Impacted Files Coverage Δ
...mework/theme/components/select/select.component.ts 89.39% <100%> (+0.15%) ⬆️
...mework/theme/components/toggle/toggle.component.ts 90% <100%> (+0.81%) ⬆️
...rk/theme/components/checkbox/checkbox.component.ts 93.05% <100%> (+0.63%) ⬆️
...mework/theme/components/option/option.component.ts 95.52% <100%> (+0.36%) ⬆️
...mework/theme/components/button/button.component.ts 87.05% <100%> (-0.45%) ⬇️
...ramework/theme/components/input/input.directive.ts 90.27% <100%> (+0.72%) ⬆️
...heme/components/form-field/form-field.component.ts 33.33% <22.22%> (-3.04%) ⬇️
...ramework/theme/components/toastr/toastr.service.ts 94.78% <0%> (-2.61%) ⬇️

@yggg yggg merged commit 8e52fc0 into akveo:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input animation on page load
1 participant